fix: make CODEX_UNSAFE_ALLOW_NO_SANDBOX disable sandboxing on all platforms #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecific sandbox attempts
christophkogler
changed the title
CashWilliams
approved these changes
May 20, 2025
|
The lack of this makes Codex not work in CI jobs. |
|
can we get this merged into main? :) |
Yeqishen
added a commit
to Yeqishen/codex
that referenced
this pull request
May 29, 2025
Yeqishen
added a commit
to Yeqishen/codex
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #973
tangential to:
#830
#848
This PR makes it so that the flag
CODEX_UNSAFE_ALLOW_NO_SANDBOXis checked first inhandle-exec-command.ts'sgetSandbox, before the platform specific sandboxing attempts are made. The flag would thus allow disabling sandboxing attempts even on thedarwinandlinuxplatforms.