Skip to content

fix: make CODEX_UNSAFE_ALLOW_NO_SANDBOX disable sandboxing on all platforms #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −5
Open

fix: make CODEX_UNSAFE_ALLOW_NO_SANDBOX disable sandboxing on all platforms #996

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8493285
moved CODEX_UNSAFE_ALLOW_NO_SANDBOX check to before making platform s…
christophkogler May 17, 2025
b051edb
ran prettier on file
christophkogler May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions codex-cli/src/utils/agent/handle-exec-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,11 @@ const isSandboxExecAvailable: Promise<boolean> = fs

async function getSandbox(runInSandbox: boolean): Promise<SandboxType> {
if (runInSandbox) {
if (process.platform === "darwin") {
if (CODEX_UNSAFE_ALLOW_NO_SANDBOX) {
// Allow running without a sandbox if the user has explicitly marked the
// environment as already being sufficiently locked-down.
return SandboxType.NONE;
} else if (process.platform === "darwin") {
// On macOS we rely on the system-provided `sandbox-exec` binary to
// enforce the Seatbelt profile. However, starting with macOS 14 the
// executable may be removed from the default installation or the user
Expand All @@ -313,10 +317,6 @@ async function getSandbox(runInSandbox: boolean): Promise<SandboxType> {
// using Landlock in a Linux Docker container from a macOS host may not
// work.
return SandboxType.LINUX_LANDLOCK;
} else if (CODEX_UNSAFE_ALLOW_NO_SANDBOX) {
// Allow running without a sandbox if the user has explicitly marked the
// environment as already being sufficiently locked-down.
return SandboxType.NONE;
}

// For all else, we hard fail if the user has requested a sandbox and none is available.
Expand Down