RHOAIENG-7226 - Allow TestMnistRay to use GPU #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiripetrlik
force-pushed
the
RHOAIENG-7226
branch
from
ed83453 to
4bb380f
Compare
jiripetrlik
requested review from
sutaakar
and removed request for
MichaelClifford and
tedhtchang
sutaakar
reviewed
Jun 27, 2024
| "with open(outfile) as f:\n", | ||
| " cluster_yaml = yaml.load(f, yaml.FullLoader)\n", | ||
| "\n", | ||
| "cluster_yaml[\"spec\"][\"workerGroupSpecs\"][0][\"template\"][\"spec\"][\"tolerations\"]=[{\"key\": \"nvidia.com/gpu\", \"value\": \"NONE\", \"effect\": \"NoSchedule\"}]\n", |
There was a problem hiding this comment.
Can you add a comment here explaining that this workaround is needed because ClusterConfiguration cannot configure tolerations yet?
sutaakar
reviewed
Jun 27, 2024
tests/odh/mnist_ray_test.go
Outdated
| @@ -71,10 +80,17 @@ func TestMnistRay(t *testing.T) { | |||
|
|
|||
| // Test configuration | |||
| jupyterNotebookConfigMapFileName := "mnist_ray_mini.ipynb" | |||
| notebook := ReadFile(test, "resources/mnist_ray_mini.ipynb") | |||
| mnist := readMnistPy(test) | |||
| if gpus_enabled == true { | |||
There was a problem hiding this comment.
Suggested change
| if gpus_enabled == true { | |
| if gpus_enabled { |
jiripetrlik
force-pushed
the
RHOAIENG-7226
branch
from
4bb380f to
0394205
Compare
sutaakar
approved these changes
Jun 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.