Run only GPU tests for PR check #585
Conversation
sutaakar
requested review from
astefanutti
and removed request for
dimakis and
Fiona-Waters
|
|
||
| set -euo pipefail | ||
| go test -timeout 60m -v ./test/e2e -json 2>&1 | tee ${CODEFLARE_TEST_OUTPUT_DIR}/gotest.log | gotestfmt | ||
| go test -timeout 60m -v -skip "^Test.*Cpu$" ./test/e2e -json 2>&1 | tee ${CODEFLARE_TEST_OUTPUT_DIR}/gotest.log | gotestfmt |
There was a problem hiding this comment.
Curious to know if you prefer keeping two physical tests instead of one controlled with an environment variable. Is it for "reporting" purpose?
There was a problem hiding this comment.
I don't have a strong opinion on that.
It is usable in downstream testing, where CPU and GPU tests are executed on different phases.
It also sufficiently distinguish those scenarios, so you can simply identify what option was executed from test name.
I kept it aligned with changes in opendatahub-io/distributed-workloads#176
There was a problem hiding this comment.
Sounds good, was more to get your opinion, thanks.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1eb260e
into
project-codeflare:main
Issue link
What changes have been made
Verification steps
Checks