Skip to content

8331051: Add an @since checker test for java.base module #18934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from
Closed

8331051: Add an @since checker test for java.base module #18934

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
0e5dcad
first `@since` checker test of the JDK. For `java.base`
nizarbenalla Apr 24, 2024
f347aec
renamed files to give them more unique filenames - add more to the co…
nizarbenalla Apr 24, 2024
d42c7f1
remove unnecessary class - jtreg comment is enough to run the test
nizarbenalla Apr 24, 2024
542ed24
Add more details to the initial comment
nizarbenalla Apr 24, 2024
32edb4d
General improvements:
nizarbenalla Apr 26, 2024
599477b
trivial change - extra parentheses
nizarbenalla Apr 29, 2024
1bdb25d
-Wrap lines at 80-100
nizarbenalla May 3, 2024
5df2151
mention packages in initial comment
nizarbenalla May 3, 2024
3f226ef
- Added some legacy modules that existed long before preview features…
nizarbenalla May 3, 2024
48c8781
- Not checking elements enclosed within a record, I doubt a record cl…
nizarbenalla May 5, 2024
ac4df85
Now only skipping the common methods that every record class will hav…
nizarbenalla May 18, 2024
7163dfb
Merge remote-tracking branch 'upstream/master' into source-based-sinc…
nizarbenalla May 18, 2024
e82dfbf
checking for null values directly rather than catching NPE
nizarbenalla May 18, 2024
fc10107
Add a few more legacy methods, needed a few more after changes to the…
nizarbenalla May 22, 2024
85b2d1a
- removed unused parameter `i`
nizarbenalla May 27, 2024
5476c99
Merge branch 'master' into source-based-since-checker
nizarbenalla Jun 4, 2024
5be962b
Improve checker report messages
nizarbenalla Jun 4, 2024
376b284
Merge remote-tracking branch 'upstream/master' into source-based-sinc…
nizarbenalla Jun 24, 2024
c09525a
(C)
nizarbenalla Jun 24, 2024
62aebb0
Move the tests to module/module_name directory for clearer naming
nizarbenalla Jun 25, 2024
12d410a
Skip over files and packages that aren't found
nizarbenalla Jun 25, 2024
441c6cc
Merge remote-tracking branch 'upstream/master' into source-based-sinc…
nizarbenalla Aug 27, 2024
636eb72
Merge remote-tracking branch 'upstream/master' into source-based-sinc…
nizarbenalla Sep 9, 2024
12df54f
Merge remote-tracking branch 'upstream/master' into source-based-sinc…
nizarbenalla Sep 10, 2024
90805b2
extend SinceChecker to now skip some packages
nizarbenalla Sep 10, 2024
542f361
avoid using `continue`, fix mistake in last commit
nizarbenalla Sep 10, 2024
45212f1
Merge remote-tracking branch 'upstream/master' into source-based-sinc…
nizarbenalla Sep 19, 2024
d355222
Change "found" to "should be" in the error messages
nizarbenalla Sep 19, 2024
c1b2dcf
Merge remote-tracking branch 'upstream/master' into source-based-sinc…
nizarbenalla Sep 20, 2024
9a17f04
remove empty if statement, debugging showed the condition is never true
nizarbenalla Sep 20, 2024
62a3406
exclude list is now module specific
nizarbenalla Sep 20, 2024
4eed8e9
Merge remote-tracking branch 'upstream/master' into source-based-sinc…
nizarbenalla Oct 2, 2024
47ba2a1
extra check to make sure we're excluding sub-packages too
nizarbenalla Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/jdk/TEST.groups
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ tier3 = \
:jdk_svc \
-:jdk_svc_sanity \
-:svc_tools \
:jdk_jpackage
:jdk_jpackage \
:jdk_since_check

# Everything not in other tiers
tier4 = \
Expand Down Expand Up @@ -661,4 +662,8 @@ jdk_containers_extended = \

jdk_core_no_security = \
:jdk_core \
-:jdk_security
-:jdk_security

# Set of tests for `@since` checks in source code documentation
jdk_since_check = \
tools/sincechecker/testjavabase/CheckSince_javaBase.java
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons May 1, 2024 •
edited by bridgekeeper bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, the symbol of a red line in a red circle is indicative of a missing final newline at the end of the file.
It is recommend that files end with exactly one newline character.

Loading