8331051: Add an `@since` checker test for `java.base` module #18934

nizarbenalla · 2024-04-24T14:10:29Z

This checker checks the values of the @since tag found in the documentation comment for an element against the release in which the element first appeared.

Real since value of an API element is computed as the oldest release in which the given API element was introduced. That is:

for modules, classes and interfaces, the release in which the element with the given qualified name was introduced
for constructors, the release in which the constructor with the given VM descriptor was introduced
for methods and fields, the release in which the given method or field with the given VM descriptor became a member of its enclosing class or interface, whether direct or inherited

Effective since value of an API element is computed as follows:

if the given element has a @since tag in its javadoc, it is used
in all other cases, return the effective since value of the enclosing element

The since checker verifies that for every API element, the real since value and the effective since value are the same, and reports an error if they are not.

Preview method are handled as per JEP 12, if @PreviewFeature is used consistently going forward then the checker doesn't need to be updated with every release. The checker has explicit knowledge of preview elements that came before JDK 14 because they weren't marked in a machine understandable way and preview elements that came before JDK 17 that didn't have @PreviewFeature.

Important note : We only check code written since JDK 9 as the releases used to determine the expected value of @since tags are taken from the historical data built into javac which only goes back that far

The intial comment at the beginning of SinceChecker.java holds more information into the program.

I already have filed issues and fixed some wrong tags like in #18640, #18032, #18030, #18055, #18373, #18954, #18972.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8331051: Add an @since checker test for java.base module (Sub-task - P4)

Reviewers

Jonathan Gibbons (@jonathan-gibbons - Reviewer) Review applies to 62a34064
Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18934/head:pull/18934
$ git checkout pull/18934

Update a local copy of the PR:
$ git checkout pull/18934
$ git pull https://git.openjdk.org/jdk.git pull/18934/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18934

View PR using the GUI difftool:
$ git pr show -t 18934

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18934.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-04-24T14:11:12Z

👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-04-24T14:12:17Z

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331051: Add an `@since` checker test for `java.base` module

Reviewed-by: jlahoda, jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 189 new commits pushed to the master branch:

b9cabbe: 8341997: Tests create files in src tree instead of scratch dir
5eae20f: 8323672: Suppress unwanted autoconf added flags in CC and CXX
6ed6dff: 8341871: Disable G1 for unsupported platforms after JDK-8334060
54c9348: 8336103: Clean up confusing Method::is_initializer
2c0c653: 8342044: Increase timeout of gc/shenandoah/oom/TestClassLoaderLeak.java
df7d6e0: 8338603: DiagnosticCommandMBean operations should standardize types for parameters
c9a536c: 8337339: gc/arguments/Test*SizeFlags.java timing out with Xcomp
f4dccfd: 8338596: Clarify handling of restricted and caller-sensitive methods
3b8a2f8: 8337269: G1ConfidencePercent interpreted inconsistently
521effe: 8340189: 8339531 incorrect for Big Endian platforms
... and 179 more: https://git.openjdk.org/jdk/compare/d6820d1324711eac95a297dd68ec94e6f6be4b35...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-04-24T14:12:38Z

@nizarbenalla The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

test/jdk/tools/sincechecker/testjavabase/SinceChecker.java

…mment at the beginning of the file

test/jdk/tools/sincechecker/SinceChecker.java

jonathan-gibbons

Various comments inline. Overall, a great start.
Consider adding more explanatory comments for the bigger items, like classes and long/important methods. Imagine a future-person looking over your shoulder, asking what the more important items do or are for.

jonathan-gibbons · 2024-04-26T23:14:12Z

test/jdk/tools/sincechecker/SinceChecker.java

+        ));
+    }
+
+    private final class EffectiveSourceSinceHelper implements AutoCloseable {


Consider putting a doc comment describing the purpose of this class. The name hints at something useful, but is not specific enough by itself.

Added it, thanks

jonathan-gibbons · 2024-04-26T23:16:57Z

test/jdk/tools/sincechecker/SinceChecker.java

+            fm.close();
+        }
+
+        private static final class PatchModuleFileManager


provide a short doc comment describing the purpose/use of this class

Added it, thanks

jonathan-gibbons · 2024-04-26T23:19:50Z

test/jdk/tools/sincechecker/SinceChecker.java

+                try {
+                    fm.close();
+                } catch (IOException closeEx) {
+                }


Consider using ex.addSuppressed(closeEx); instead of just dropping the exception

Fixed in 32edb4d

test/jdk/tools/sincechecker/SinceChecker.java

jonathan-gibbons · 2024-04-26T23:24:19Z

test/jdk/tools/sincechecker/SinceChecker.java

+        public String introducedStable;
+    }
+
+    //these were preview in before the introduction of the @PreviewFeature


Just curious: where do you find this information?

Used a script to get all the elements with @Deprecated(forRemoval=true, since=...), @jdk.internal.preview, {@preview Associated with .... in their javadoc.
And then had to cross reference with a document that had all the ids

Thanks for the update

- added more detail to the initial comment - ordered imports correctly - renamed methods to be more consistent - added predicate methods and 'isDocumented' 'isMember' - added doc comments describing purpose of 'EffectiveSourceSinceHelper'

mlbridge · 2024-04-29T09:16:27Z

Webrevs

jddarcy · 2024-04-29T16:48:07Z

If not already planned, I recommend a much broader discussion/announcement of this test before it goes back. For example, a message to jdk-dev stating "The value of @since tags will be tested now by a tier $N test. This is how you run the test before a push. Here are rules for some tricky cases like introducing a covariant override." etc.

jonathan-gibbons · 2024-05-01T20:53:08Z

test/jdk/tools/sincechecker/SinceChecker.java

+- This checker checks the values of the `@since` tag found in the documentation comment for an element against the release in which the element first appeared.
+- The source code containing the documentation comments is read from `src.zip` in the release of JDK used to run the test.
+- The releases used to determine the expected value of `@since` tags are taken from the historical data built into `javac`.


(Minor, suggest wrapping lines somewhere between 80-100 characters long)

My idea was that, even when comparing files in a merge conflit, there wouldn't be problems here.

But I will fix, some lines in the code are a bit long as well

jonathan-gibbons · 2024-05-01T20:58:22Z

test/jdk/tools/sincechecker/SinceChecker.java

+                        processModuleCheck(elements.getModuleElement(moduleName), ct, packagePath, javadocHelper);
+                    } catch (Exception e) {
+                        e.printStackTrace();
+                        error("Initiating javadocHelperFailed " + e.getMessage());


You probably want just e, not e.getMessage() because e (actually e.toString()) will include the name of the exception as well, whereas e.getMessage() does not.)

jonathan-gibbons · 2024-05-01T21:02:53Z

test/jdk/tools/sincechecker/SinceChecker.java

+            URI uri = URI.create("jar:" + srcZip.toUri());
+            try (FileSystem zipFO = FileSystems.newFileSystem(uri, Collections.emptyMap())) {
+                Path root = zipFO.getRootDirectories().iterator().next();
+                Path packagePath = root.resolve(moduleName);


Here, and in uses of this name, including in method signatures, it is strange to see the variable named packagePath since it appears to be the path of the unnamed package in the module.

modulePath would likely be a better name, unless you are worried about possible confusion with the --module-path option, in which case maybe moduleDir or moduleDirectory would work.

jonathan-gibbons · 2024-05-01T21:03:28Z

test/jdk/tools/sincechecker/SinceChecker.java

+        }
+    }
+
+    private void processModuleCheck(ModuleElement moduleElement, JavacTask ct, Path packagePath, EffectiveSourceSinceHelper javadocHelper) {


see comment line 223, about use of packagePath

jonathan-gibbons · 2024-05-01T21:03:53Z

test/jdk/tools/sincechecker/SinceChecker.java

+        }
+    }
+
+    private String getModuleVersionFromFile(Path packagePath) {


see comment line 223, about packagePath

jonathan-gibbons · 2024-05-01T21:04:40Z

test/jdk/tools/sincechecker/SinceChecker.java

+        return version;
+    }
+
+    private String getPackageVersionFromFile(Path packagePath, ModuleElement.ExportsDirective ed) {


see comment line 223, about packagePath

jonathan-gibbons · 2024-05-01T21:05:54Z

test/jdk/tools/sincechecker/SinceChecker.java

+        public String introducedStable;
+    }
+
+    //these were preview in before the introduction of the @PreviewFeature


Thanks for the update

jonathan-gibbons · 2024-05-01T21:08:43Z

test/jdk/TEST.groups

+# Set of tests for `@since` checks in source code documentation
+jdk_since_check = \
+   tools/sincechecker/testjavabase/CheckSince_javaBase.java


Generally, the symbol of a red line in a red circle is indicative of a missing final newline at the end of the file.
It is recommend that files end with exactly one newline character.

jonathan-gibbons · 2024-05-01T21:12:04Z

test/jdk/tools/sincechecker/SinceChecker.java

+note on rules for Real and effective `@since:
+
+Real since value of an API element is computed as the oldest release in which the given API element was introduced. That is:
+- for modules, classes and interfaces, the release in which the element with the given qualified name was introduced


What about packages? packages should be in this list as well.

Small oversight, will fix

nizarbenalla · 2024-05-01T23:28:20Z

test/jdk/tools/sincechecker/SinceChecker.java

+        Path pkgInfo = packagePath.resolve(ed.getPackage()
+                        .getQualifiedName()
+                        .toString()
+                        .replaceAll("\\.", "/")


Note for readers: I will change this tomorrow to be more platform agnostic using File.separatorChar instead

Replaced with .replace(".", File.separator)

hns · 2024-05-02T13:49:43Z

test/jdk/tools/sincechecker/SinceChecker.java

+
+
+/*
+- This checker checks the values of the `@since` tag found in the documentation comment for an element against the release in which the element first appeared.


In addition to the long lines mentioned by Jon which make the comments hard to read, I find it strange that every sentence is formatted as a list item with a leading dash. I think it's ok when describing different parts/steps of the algorithm, but at least the first sentence in the comment should not be a list item IMO.

Fixed, thanks.

hns · 2024-05-02T14:06:25Z

test/jdk/tools/sincechecker/SinceChecker.java

+
+    public static void main(String[] args) throws Exception {
+        if (args.length == 0) {
+            throw new SkippedException("Test module not specified");


I don't think SkippedException is the right exception to throw here, since invoking the method with a missing argument is probably a configuration error that shouldn't be ignored. Maybe IllegalArgumentException or just RuntimeException?

Fixed it, now throwing IllegalArgumentException.

hns · 2024-05-02T14:28:02Z

test/jdk/tools/sincechecker/SinceChecker.java

+                .forEach(nestedClass -> processClassElement(nestedClass, version, types, elements));
+    }
+
+    public void persistElement(Element explicitOwner, Element element, Types types, String version) {


I'm not sure persistElement is a good name for this, it sounds like the element is being stored permanently (beyond the runtime of this program). I can't think of a really good name, but I think processElement would be ok.

hns · 2024-05-02T14:42:39Z

test/jdk/tools/sincechecker/SinceChecker.java

+            Path testJdk = Paths.get(System.getProperty("test.jdk"));
+            srcZip = testJdk.getParent().resolve("images").resolve("jdk").resolve("lib").resolve("src.zip");
+        }
+        if (!Files.exists(srcZip) && !Files.isDirectory(srcZip)) {


This condition looks wrong. If exists returns false, it also implies that isDirectory returns false. I think there's no need to check for a (not-)directory here.

Fixed in 3f226ef, I now only check if the file is readable.

-Changes `e.getMessages` to `e` -`File.separator` to be platform indepedant -Added a newline character at the end of files -Rename `persistElement` to `processElement` -Now throwing IllegalArgumentException instead of SkippedException

… (they were incubating) - Not checking elements enclosed withing a record - Only check if the file is readable using `Files.isReadable` - Dropped the use of `Files.exists` and `Files.isDirectory` - Use `--add-modules` option now to resolve certain modules

…ass will change after being created - Added a null check as `toString` can return an exception

…e-checker

nizarbenalla · 2024-09-19T16:40:48Z

I performed a merge and a tiny change to the error message by the test.
The major changes since the last review are that I now skip packages if they are not found, and I added an exclude list to skip certain packages if we wish to do so.

Here is an example of the error output of the tool

STDERR:
src/java.base/java/lang/classfile/TypeKind.java:73 field: java.lang.classfile.TypeKind:BOOLEAN: `@since` version: 22; should be: 24
src/java.base/java/lang/classfile/TypeKind.java:80 field: java.lang.classfile.TypeKind:BYTE: `@since` version: 22; should be: 24
src/java.base/java/lang/classfile/TypeKind.java:87 field: java.lang.classfile.TypeKind:CHAR: `@since` version: 22; should be: 24
src/java.base/java/lang/classfile/TypeKind.java:94 field: java.lang.classfile.TypeKind:SHORT: `@since` version: 22; should be: 24
src/java.base/java/lang/classfile/TypeKind.java:99 field: java.lang.classfile.TypeKind:INT: `@since` version: 22; should be: 24
src/java.base/java/lang/classfile/TypeKind.java:103 field: java.lang.classfile.TypeKind:LONG: `@since` version: 22; should be: 24
src/java.base/java/lang/classfile/TypeKind.java:107 field: java.lang.classfile.TypeKind:FLOAT: `@since` version: 22; should be: 24
src/java.base/java/lang/classfile/TypeKind.java:111 field: java.lang.classfile.TypeKind:DOUBLE: `@since` version: 22; should be: 24
src/java.base/java/lang/classfile/TypeKind.java:117 field: java.lang.classfile.TypeKind:REFERENCE: `@since` version: 22; should be: 24
src/java.base/java/lang/classfile/TypeKind.java:125 field: java.lang.classfile.TypeKind:VOID: `@since` version: 22; should be: 24
src/java.base/java/lang/classfile/TypeKind.java:143 method: java.lang.constant.ClassDesc java.lang.classfile.TypeKind.upperBound(): `@since` version: 22; should be: 24
java.lang.Exception: The `@since` checker found 64 problems
        at SinceChecker.checkModule(SinceChecker.java:265)
        at SinceChecker.main(SinceChecker.java:126)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:573)
        at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
        at java.base/java.lang.Thread.run(Thread.java:1576)

jonathan-gibbons · 2024-09-19T22:12:58Z

test/jdk/tools/sincechecker/SinceChecker.java

+
+            String version = String.valueOf(i);
+            Elements elements = ct.getElements();
+            elements.getModuleElement("java.base"); // forces module graph to be instantiated


@lahodaj I've always considered this kind of line to be a workaround; it would be nice if we could have an RFE so this kind of line was unnecessary in code that wants to introspect the elements

Thanks. I've filled:
https://bugs.openjdk.org/browse/JDK-8341342

jonathan-gibbons · 2024-09-19T22:20:39Z

test/jdk/tools/sincechecker/SinceChecker.java

+                version = effectiveSinceVersion(element.getEnclosingElement().getEnclosingElement(), element.getEnclosingElement(), types, elementUtils);
+            }
+            if (version == null) {
+                //may be null for private elements


empty statement for if...

jonathan-gibbons · 2024-09-19T22:22:17Z

test/jdk/tools/sincechecker/SinceChecker.java

+import com.sun.tools.javac.util.Pair;
+import jtreg.SkippedException;
+
+/*


Good comment.

jonathan-gibbons

Generally very good. It's getting to be a really nice piece of functionality.

I added one suggestion for a minor improvement, about setting up the `EXCLUDE_LIST in a more module-specific way. The intent is that if we need to make module-specific changes to the exclude list in times going forward, we should do that in the module-specific test invocation, and not in the main module-independent code.

jonathan-gibbons · 2024-09-19T22:26:49Z

test/jdk/tools/sincechecker/SinceChecker.java

+    private static final Set<String> EXCLUDE_LIST = Set.of(
+            "java.lang.classfile"
+    );


This should not really be here, in the general code for a SinceChecker for all modules.

It would be better if this info was provided in command-line options, given when the test is run from the module-specific test (i.e. CheckSince_javaBase.java).

This means you will have to write some additional simple option decoding in the main method, starting line 21.

jonathan-gibbons · 2024-09-19T22:32:22Z

test/jdk/tools/sincechecker/modules/java_base/CheckSince_javaBase.java

+ * @modules jdk.compiler/com.sun.tools.javac.api
+ *          jdk.compiler/com.sun.tools.javac.util
+ *          jdk.compiler/com.sun.tools.javac.code
+ * @run main SinceChecker java.base


See the comment about init-ing the EXCLUDE_LIST in the main SinceChecker, at about line 112.

You are already passing a module name as an option to the main test. Maybe the command here on line 33 could be something like

@run main SinceChecker java.base --exclude java.lang.classfile

where the argument after --exclude is (logically) a comma-separated list of items to exclude. You could also do a whitespace-separated list up to the next option (i.e. item beginning with -) or end of the list. In other words make it future-proof against adding more options in future.

jonathan-gibbons · 2024-09-19T22:50:05Z

For discussion:

I see that in GitHub Actions, the test passes on all platforms. (That's good!). But it's not clear to me that it needs to run on all platforms. Generally, the API should be the same on all platforms, right (After all, we only generate one set of API documentation.)

So, the question becomes, can a test determine if it is being run in a multi-platform context? We presumably don't want to stop the test running whenever a user runs it locally on their platform of choice, but equally, if the test is being run on many platforms, that's an unnecessary use/waste of resources. But, I guess we run a lot of tests that are essentially platform-independent on all platforms, although I guess there're are also testing the product running on top of the JVM, whereas here. we're primarily just checking the source.

Anyway, this is really just an abstract academic discussion, not a blocker in any way for the PR.

…e-checker

lahodaj

Looks reasonable to me.

…e-checker

lahodaj

Still looks good to me.

nizarbenalla · 2024-10-15T16:15:40Z

Can we maybe set the reviewer count to 1? This needs an additional review and the last change was small.

lahodaj · 2024-10-15T20:02:55Z

/reviewers 1

openjdk · 2024-10-15T20:03:19Z

@lahodaj
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

nizarbenalla · 2024-10-16T10:17:19Z

Thank you for the reviews; all. And the help to getting this work integrated.

/integrate

openjdk · 2024-10-16T10:17:47Z

Going to push as commit c81aa75.
Since your change was applied there have been 198 commits pushed to the master branch:

ebc17c7: 8339637: (tz) Update Timezone Data to 2024b
e7cf25c: 8340801: Disable ubsan checks in some awt/2d coding
577babf: 8334010: VM crashes with ObjectAlignmentInBytes > GCCardSizeInBytes
b9b0bd0: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing
724de68: 8342081: Shenandoah: Remove extra ShenandoahMarkUpdateRefsSuperClosure
e4ff553: 8341931: os_linux gtest uses lambdas with explicit capture lists
e94e3bb: 8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust
6d7e679: 8340790: Open source several AWT Dialog tests - Batch 4
86ce19e: 8341142: Maintain a single source file for sun.net.www.protocol.jar.JarFileFactory
b9cabbe: 8341997: Tests create files in src tree instead of scratch dir
... and 188 more: https://git.openjdk.org/jdk/compare/d6820d1324711eac95a297dd68ec94e6f6be4b35...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-10-16T10:17:55Z

@nizarbenalla Pushed as commit c81aa75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

first @since checker test of the JDK. For java.base

0e5dcad

openjdk bot added the core-libs [email protected] label Apr 24, 2024

jonathan-gibbons reviewed Apr 24, 2024

View reviewed changes

test/jdk/tools/sincechecker/testjavabase/SinceChecker.java Outdated Show resolved Hide resolved

nizarbenalla added 3 commits April 24, 2024 16:41

renamed files to give them more unique filenames - add more to the co…

f347aec

…mment at the beginning of the file

remove unnecessary class - jtreg comment is enough to run the test

d42c7f1

Add more details to the initial comment

542ed24

jonathan-gibbons reviewed Apr 24, 2024

View reviewed changes

nizarbenalla mentioned this pull request Apr 25, 2024

8330954: since-checker - Fix remaining @ since tags in java.base #18954

Closed

3 tasks

jonathan-gibbons reviewed Apr 26, 2024

View reviewed changes

nizarbenalla added 2 commits April 29, 2024 02:20

General improvements:

32edb4d

- added more detail to the initial comment - ordered imports correctly - renamed methods to be more consistent - added predicate methods and 'isDocumented' 'isMember' - added doc comments describing purpose of 'EffectiveSourceSinceHelper'

trivial change - extra parentheses

599477b

nizarbenalla marked this pull request as ready for review April 29, 2024 09:12

openjdk bot added the rfr Pull request is ready for review label Apr 29, 2024

jonathan-gibbons reviewed May 1, 2024

View reviewed changes

nizarbenalla commented May 2, 2024

View reviewed changes

hns reviewed May 2, 2024

View reviewed changes

nizarbenalla added 4 commits May 3, 2024 01:16

-Wrap lines at 80-100

1bdb25d

-Changes `e.getMessages` to `e` -`File.separator` to be platform indepedant -Added a newline character at the end of files -Rename `persistElement` to `processElement` -Now throwing IllegalArgumentException instead of SkippedException

mention packages in initial comment

5df2151

- Not checking elements enclosed within a record, I doubt a record cl…

48c8781

…ass will change after being created - Added a null check as `toString` can return an exception

This was referenced May 10, 2024

8332014: since-checker - Fix @ since tags in jdk.jshell #19166

Closed

8332103: since-checker - Add missing @ since tags to java.desktop #19192

Closed

nizarbenalla added 2 commits September 19, 2024 17:25

Merge remote-tracking branch 'upstream/master' into source-based-sinc…

45212f1

…e-checker

Change "found" to "should be" in the error messages

d355222

jonathan-gibbons reviewed Sep 19, 2024

View reviewed changes

jonathan-gibbons suggested changes Sep 19, 2024

View reviewed changes

nizarbenalla added 3 commits September 20, 2024 11:37

Merge remote-tracking branch 'upstream/master' into source-based-sinc…

c1b2dcf

…e-checker

remove empty if statement, debugging showed the condition is never true

9a17f04

exclude list is now module specific

62a3406

jonathan-gibbons approved these changes Sep 20, 2024

View reviewed changes

lahodaj approved these changes Oct 1, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2024

nizarbenalla added 2 commits October 2, 2024 11:59

Merge remote-tracking branch 'upstream/master' into source-based-sinc…

4eed8e9

…e-checker

extra check to make sure we're excluding sub-packages too

47ba2a1

openjdk bot removed the ready Pull request is ready to be integrated label Oct 2, 2024

lahodaj approved these changes Oct 15, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 15, 2024

openjdk bot added the integrated Pull request has been integrated label Oct 16, 2024

openjdk bot closed this Oct 16, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2024

nizarbenalla deleted the source-based-since-checker branch October 16, 2024 13:56



		/*
		- This checker checks the values of the `@since` tag found in the documentation comment for an element against the release in which the element first appeared.

8331051: Add an @since checker test for java.base module #18934

8331051: Add an @since checker test for java.base module #18934

Conversation

nizarbenalla commented Apr 24, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 24, 2024

openjdk bot commented Apr 24, 2024 • edited Loading

openjdk bot commented Apr 24, 2024

jonathan-gibbons left a comment • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons Apr 26, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonathan-gibbons Apr 26, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonathan-gibbons Apr 26, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonathan-gibbons Apr 26, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonathan-gibbons May 1, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlbridge bot commented Apr 29, 2024 • edited Loading

Webrevs

jddarcy commented Apr 29, 2024

jonathan-gibbons May 1, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonathan-gibbons May 1, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons May 1, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons May 1, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons May 1, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons May 1, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons May 1, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons May 1, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons May 1, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nizarbenalla commented Sep 19, 2024

jonathan-gibbons Sep 19, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonathan-gibbons Sep 19, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons Sep 19, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons left a comment • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons Sep 19, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons Sep 19, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

jonathan-gibbons commented Sep 19, 2024 • edited by bridgekeeper bot Loading

lahodaj left a comment

Choose a reason for hiding this comment

lahodaj left a comment

Choose a reason for hiding this comment

nizarbenalla commented Oct 15, 2024

8331051: Add an `@since` checker test for `java.base` module #18934

8331051: Add an `@since` checker test for `java.base` module #18934

nizarbenalla commented Apr 24, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Apr 24, 2024 •

edited

Loading

jonathan-gibbons left a comment •

edited by bridgekeeper bot

Loading

jonathan-gibbons Apr 26, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons Apr 26, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons Apr 26, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons Apr 26, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons May 1, 2024 •

edited by bridgekeeper bot

Loading

mlbridge bot commented Apr 29, 2024 •

edited

Loading

jonathan-gibbons May 1, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons May 1, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons May 1, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons May 1, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons May 1, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons May 1, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons May 1, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons May 1, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons May 1, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons Sep 19, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons Sep 19, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons Sep 19, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons left a comment •

edited by bridgekeeper bot

Loading

jonathan-gibbons Sep 19, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons Sep 19, 2024 •

edited by bridgekeeper bot

Loading

jonathan-gibbons commented Sep 19, 2024 •

edited by bridgekeeper bot

Loading