8329718: Incorrect @since tags in elements in jdk.compiler and java.compiler

[nizarbenalla]

This PR aims to add @since tags in elements in both jdk.compiler and java.compiler.
A lot of these changes have to do with handling of preview features.

The existing rules for handling of @since for preview elements:

• When an element is still marked as preview, the @since should be the first JDK release where the element was added.
• If the element is no longer marked as preview, the @since should be the first JDK release where it was no longer preview.

It is tricky to check these, the way preview elements were annotated before the inroduction of @Previewfeature in JDK 17:

• in jdk 12-13 they were annotated with @Deprecated(forRemoval=true, since=...)
• in jdk 14-15 they were annotated with @jdk.internal.preview or with {@preview Associated with .... in the javadoc comment

If you're reviewing these changes, Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329718: Incorrect @<!---->since tags in elements in jdk.compiler and java.compiler (Sub-task - P4)

Reviewers

• Joe Darcy (@jddarcy - Reviewer) ⚠️ Review applies to 558abe6e
• Jonathan Gibbons (@jonathan-gibbons - Reviewer) ⚠️ Review applies to 558abe6e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18972/head:pull/18972
$ git checkout pull/18972

Update a local copy of the PR:
$ git checkout pull/18972
$ git pull https://git.openjdk.org/jdk.git pull/18972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18972

View PR using the GUI difftool:
$ git pr show -t 18972

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18972.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329718: Incorrect `@since` tags in elements in jdk.compiler and java.compiler

Reviewed-by: darcy, jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 9ca90cc: 8332610: Remove unused nWakeups in ObjectMonitor
• 92d3350: 8331920: ubsan: g1CardSetContainers.inline.hpp:266:5: runtime error: index 2 out of bounds for type 'G1CardSetHowl::ContainerPtr [2]' reported

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jddarcy, @jonathan-gibbons) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@nizarbenalla The following labels will be automatically applied to this pull request:

• compiler
• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (38514761)
• 00: Full (558abe6e)

[jddarcy]

The java.compiler changes looks fine.

[nizarbenalla]

Thanks Joe

[jonathan-gibbons]

jdk.compiler changes look OK

[nizarbenalla]

I did an other pass over these and I made a small change to visitYield, it went out of preview in JDK 14, not JDK 15. I hope it's fine.

Here it is in preview
Here it is out of preview

/integrate

[openjdk]

@nizarbenalla
Your change (at version 3851476) is now ready to be sponsored by a Committer.

[vicente-romero-oracle]

/sponsor

[openjdk]

Going to push as commit d59c12f.
Since your change was applied there have been 7 commits pushed to the master branch:

• b4d1454: 8332740: [BACKOUT] JDK-8331081 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version
• 37c4778: 8332096: hotspot-ide-project fails with this-escape
• 2170e99: 8331081: 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version
• a0c5714: 8332071: Convert package.html files in java.management.rmi to package-info.java
• afed7d0: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic
• 9ca90cc: 8332610: Remove unused nWakeups in ObjectMonitor
• 92d3350: 8331920: ubsan: g1CardSetContainers.inline.hpp:266:5: runtime error: index 2 out of bounds for type 'G1CardSetHowl::ContainerPtr [2]' reported

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle @nizarbenalla Pushed as commit d59c12f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.