8332014: since-checker - Fix @ since tags in jdk.jshell

[nizarbenalla]

Please review this small change that aims to make the @since in this module more accurate, these bugs were reported by the checker tool at #18934

-field: jdk.jshell.Snippet.SubKind:RECORD_SUBKIND
This should have @since 17 as it was a Preview element in JDK 14-16

-method: java.util.List jdk.jshell.SourceCodeAnalysis.sourceToSnippets(java.lang.String)
-method: int jdk.jshell.tool.JavaShellToolBuilder.start(java.lang.String[])

both should have @since 10 instead of 9

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8332014: since-checker - Fix @ since tags in jdk.jshell (Sub-task - P4)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19166/head:pull/19166
$ git checkout pull/19166

Update a local copy of the PR:
$ git checkout pull/19166
$ git pull https://git.openjdk.org/jdk.git pull/19166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19166

View PR using the GUI difftool:
$ git pr show -t 19166

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19166.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332014: since-checker - Fix @ since tags in jdk.jshell

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 632 new commits pushed to the master branch:

• 741a0f3: 8334241: Adjust API docs side bar dimensions
• 4ce8822: 8334037: Local class creation in lambda in pre-construction context crashes javac
• 7f6804c: 8334872: BigEndian: java/lang/invoke/condy Tests failing since JDK-8294960
• e139005: 8333994: NMT: call stacks should show source information
• b88af94: 8269870: PS: Membar in PSPromotionManager::copy_unmarked_to_survivor_space could be relaxed
• a5f401f: 8334650: Add debug information about whether an Assertion Predicate is for the init or last value
• 25c3845: 8333133: Simplify QuickSort::sort
• c66f785: 8334505: RISC-V: Several tests fail when MaxVectorSize does not match VM_Version::_initial_vector_length
• f101e15: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538
• b3bf31a: 8333542: Breakpoint in parallel code does not work
• ... and 622 more: https://git.openjdk.org/jdk/compare/8af606fb8cdb3a6ecdfe4cddd79f228b64d5fc80...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lahodaj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@nizarbenalla The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0145bfd6)
• 00: Full (2e11f9b7)

[bridgekeeper]

@nizarbenalla This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[nizarbenalla]

I wish to keep this open.

[lahodaj]

Looks good to me. Thanks!

[nizarbenalla]

Thank you for the review Jan!

/integrate

[openjdk]

@nizarbenalla
Your change (at version 0145bfd) is now ready to be sponsored by a Committer.

[lahodaj]

/sponsor

[openjdk]

Going to push as commit 0fc5b27.
Since your change was applied there have been 648 commits pushed to the master branch:

• 9d20b58: 8334328: Reduce object allocation for FloatToDecimal and DoubleToDecimal
• 9bb675f: 8334719: (se) Deferred close of SelectableChannel may result in a Selector doing the final close before concurrent I/O on channel has completed
• 6682305: 8334779: Test compiler/c1/CanonicalizeArrayLength.java is timing out
• 3796fdf: 8328536: javac - crash on unknown type referenced in yield statement
• 07bc523: 8334670: SSLSocketOutputRecord buffer miscalculation
• 4ebb771: 8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator
• 817edcb: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock
• bffc848: 8333755: NumberFormat integer only parsing breaks when format has suffix
• b5d5896: 8335108: Build error after JDK-8333658 due to class templates
• 5883a20: 8334437: De-duplicate ProxyMethod list creation
• ... and 638 more: https://git.openjdk.org/jdk/compare/8af606fb8cdb3a6ecdfe4cddd79f228b64d5fc80...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj @nizarbenalla Pushed as commit 0fc5b27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.