-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8335727: since-checker: Add @since
tags to ClassFile::transformClass and CodeBuilder
#20041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@nizarbenalla The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot that renames are new additions too! I am too ignorant.
No worries! I noticed these by chance today. |
Just FYI: move from preview to final will bump all see: #19826 |
Thank you, I created this PR because the test in #18934 failed when I was running it. If ClassFile goes final before the checker is integrated then this should be fine. |
I will close this for now. |
Please review this simple doc only change.
Some methods in ClassFile API were renamed recently as part of JDK-8335290 and JDK-8335110 and need to have
@since 24
, as they are essentially new methods.Thanks!
Progress
Issue
@<!---->since
tags to ClassFile::transformClass and CodeBuilder (Sub-task - P4)Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20041/head:pull/20041
$ git checkout pull/20041
Update a local copy of the PR:
$ git checkout pull/20041
$ git pull https://git.openjdk.org/jdk.git pull/20041/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20041
View PR using the GUI difftool:
$ git pr show -t 20041
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20041.diff
Webrev
Link to Webrev Comment