8354231: x86: Purge FPU support from (Macro)Assembler after 32-bit x86 removal

[shipilev]

There are lots of cleanups possible in (Macro)Assembler after 32-bit x86 removal. This cleanup is focused on removing the large parts of x87 FPU support that are no longer needed. Note that some math stubs are actually using x87 FPU in a very limited manner, but the implementations use separate definitions (under LP64). Those are left alone, and we clean up x86_32 code here.

Additional testing:

• Linux x86_64 server fastdebug, all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354231: x86: Purge FPU support from (Macro)Assembler after 32-bit x86 removal (Sub-task - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) Review applies to 81aef47d
• Coleen Phillimore (@coleenp - Reviewer)
• Vladimir Ivanov (@iwanowww - Reviewer) Review applies to 81aef47d

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24558/head:pull/24558
$ git checkout pull/24558

Update a local copy of the PR:
$ git checkout pull/24558
$ git pull https://git.openjdk.org/jdk.git pull/24558/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24558

View PR using the GUI difftool:
$ git pr show -t 24558

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24558.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354231: x86: Purge FPU support from (Macro)Assembler after 32-bit x86 removal

Reviewed-by: coleenp, kvn, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 1d7138f: 8353614: JFR: jfr print --exact
• e604bb9: 8352731: Compiler workaround to forcibly set "-Xlint:-options" can be removed
• 2321722: 8346109: Create JDK taglet for additional preview notes
• ... and 9 more: https://git.openjdk.org/jdk/compare/cf0308b2716053eb7c547cfcc6b160589cd6a2b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full (a7c7bc9d)
• 00: Full (81aef47d)

[vnkozlov]

Good.

[coleenp]

Thanks for breaking this up like this.

[iwanowww]

Looks good.

[shipilev]

Resolved a simple merge conflict.

[vnkozlov]

Re-approve

[shipilev]

Thanks! Here goes.

/integrate

[openjdk]

@shipilev This pull request has not yet been marked as ready for integration.

[shipilev]

@shipilev This pull request has not yet been marked as ready for integration.

Bad bot! Tsk-tsk-tsk.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit 2595c47.
Since your change was applied there have been 19 commits pushed to the master branch:

• b539fb0: 8352877: Opensource Several Font related tests - Batch 1
• 5d97608: 8254622: Hide superclasses from conditionally exported packages
• ed756b9: 8352922: Refactor client classes javadoc to use @throws instead of @exception
• ... and 16 more: https://git.openjdk.org/jdk/compare/cf0308b2716053eb7c547cfcc6b160589cd6a2b0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 2595c47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.