fix: template of Other runs in tkn-pac describe command #2018
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch the output of other runs in the tkn pac describe command was not aligned properly Hence, with this patch it fixes and aligns the output Signed-off-by: PuneetPunamiya <[email protected]>
|
/test |
|
e2e test is not running for puneet at the moment which is expected since not yet in allowed list |
But should it be successful ? because one could merge this, without the test running (vs having something failing or in pending that "would" prevent that) |
|
i solved it differently see #2024 |
zakisk
reviewed
Apr 7, 2025
| @@ -32,7 +32,7 @@ | |||
|
|
|||
| {{ $.ColorScheme.Underline "Other Runs:" }} | |||
|
|
|||
| {{ $.ColorScheme.Bold "STATUS:" }} {{ $.ColorScheme.Bold "Event" }} {{ $.ColorScheme.Bold "Branch" }} {{ $.ColorScheme.Bold "SHA" }} {{ $.ColorScheme.Bold "STARTED TIME" }} {{ $.ColorScheme.Bold "DURATION" }} {{ $.ColorScheme.Bold "PIPELINERUN" }} | |||
There was a problem hiding this comment.
@PuneetPunamiya why colon is removed?
There was a problem hiding this comment.
There's no such reason, I can add it back again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch the output of other runs in the tkn pac describe command was not aligned properly
Hence, with this patch it fixes and aligns the output
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
(update the documentation accordingly)