Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: template of Other runs in tkn-pac describe command #2018

Merged
merged 1 commit into from
Apr 8, 2025
+4 −4
Merged

fix: template of Other runs in tkn-pac describe command #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cmd/tknpac/describe/templates/describe.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

{{ $.ColorScheme.Underline "Other Runs:" }}

{{ $.ColorScheme.Bold "STATUS:" }} {{ $.ColorScheme.Bold "Event" }} {{ $.ColorScheme.Bold "Branch" }} {{ $.ColorScheme.Bold "SHA" }} {{ $.ColorScheme.Bold "STARTED TIME" }} {{ $.ColorScheme.Bold "DURATION" }} {{ $.ColorScheme.Bold "PIPELINERUN" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PuneetPunamiya why colon is removed?

Copy link
Contributor Author

@PuneetPunamiya PuneetPunamiya Apr 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no such reason, considering UX I removed it, I can add it back again if we don't want to change

{{ $.ColorScheme.Bold "STATUS" }} {{ $.ColorScheme.Bold "Event" }} {{ $.ColorScheme.Bold "Branch" }} {{ $.ColorScheme.Bold "SHA" }} {{ $.ColorScheme.Bold "STARTED TIME" }} {{ $.ColorScheme.Bold "DURATION" }} {{ $.ColorScheme.Bold "PIPELINERUN" }}
{{- range $i, $st := (slice .Statuses 1 (len .Statuses)) }}
{{ formatStatus $st $.ColorScheme $.Clock }}
{{- end }}
Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/tknpac/describe/testdata/TestDescribe-live_run_and_repository_run.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ Duration: ---

Other Runs:

STATUS: Event Branch SHA STARTED TIME DURATION PIPELINERUN
Success propseryouplaboun TargetBranch SHA 16 minutes ago 1 minute pipelinerun1
STATUS Event Branch SHA STARTED TIME DURATION PIPELINERUN
Success propseryouplaboun TargetBranch SHA 16 minutes ago 1 minute pipelinerun1
2 changes: 1 addition & 1 deletion pkg/cmd/tknpac/describe/testdata/TestDescribe-multiple_repo_status.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ Duration: 1 minute

Other Runs:

STATUS: Event Branch SHA STARTED TIME DURATION PIPELINERUN
STATUS Event Branch SHA STARTED TIME DURATION PIPELINERUN
Success pull_request TargetBranch SHA2 18 minutes ago 1 minute pipelinerun2
Success push PushBranch SHA 20 minutes ago 1 minute pipelinerun3
Loading