NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API

[isabella-janssen]

The MCO did not implement the functionality to populate the Spec.PinnedImageSets field on a PIS application. This cleanup is necessary to avoid GAing the MCN API with an unpopulated field. See #2256 (comment) for more information.

Work Included:

• Tombstoning of Spec.PinnedImageSets field and corresponding MachineConfigNodeSpecPinnedImageSet type definition in the MCN API.
• Cleanup of tests no longer applicable.

[openshift-ci]

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[isabella-janssen]

/assign @RishabhSaini @hexfusion

[isabella-janssen]

/test all

[hexfusion]

/lgtm

Per our conversation, the canonical pinned imageset spec is defined in the resource itself and deployed/reconciled on the pool level. MCN provides a per-node status to avoid needing to use annotations on the node level. For this reason, spec is not used/needed and ok to remove.

[isabella-janssen]

/test integration

[isabella-janssen]

/test integration

[isabella-janssen]

/test integration

[JoelSpeed]

/lgtm
/override ci/prow/verify-crd-schema

Since this is a v1alpha1 API, we don't have to worry about folks upgrading, we are safe to remove this field

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, isabella-janssen, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

/lgtm
/override ci/prow/verify-crd-schema

Since this is a v1alpha1 API, we don't have to worry about folks upgrading, we are safe to remove this field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202504021210.p0.g3d7abe9.assembly.stream.el9.
All builds following this will include this PR.