MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

[isabella-janssen]

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code and the API code part of MCO-1630: Generate v1 crds for PIS api#2257 with tech preview enabled. Note that the API PR version is needed due to the v1 CRD deployments. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962,openshift/api#2257 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-110-176.us-west-2.compute.internal
Name:         ip-10-0-110-176.us-west-2.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
  Creation Timestamp:  2025-04-03T22:08:41Z
  Generation:          2
  Owner References:
    API Version:     v1
    Kind:            Node
    Name:            ip-10-0-110-176.us-west-2.compute.internal
    UID:             f3d946e9-24d4-4b96-b4a7-4536d79c73a8
  Resource Version:  18006
  UID:               7f03657f-d52a-4a48-b835-370f22fc773a
Spec:
  Config Version:
    Desired:  rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
  Node:
    Name:  ip-10-0-110-176.us-west-2.compute.internal
  Pool:
    Name:  worker
Status:
  Conditions:
    Last Transition Time:  2025-04-03T22:08:41Z
    Message:               All pinned image sets complete
    Reason:                AsExpected
    Status:                False
    Type:                  PinnedImageSetsProgressing
    Last Transition Time:  2025-04-03T22:08:41Z
    Message:               This node has not yet entered the UpdatePrepared phase
    Reason:                NotYetOccurred
    Status:                False
    Type:                  UpdatePrepared
    Last Transition Time:  2025-04-03T22:08:41Z
    Message:               This node has not yet entered the UpdateExecuted phase
    Reason:                NotYetOccurred
    Status:                False
    Type:                  UpdateExecuted
    Last Transition Time:  2025-04-03T22:08:41Z
    Message:               This node has not yet entered the UpdatePostActionComplete phase
    Reason:                NotYetOccurred
    Status:                False
    Type:                  UpdatePostActionComplete
    Last Transition Time:  2025-04-03T22:09:55Z
    Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: Uncordoned Node as part of completing upgrade phase
    Reason:                Uncordoned
    Status:                False
    Type:                  UpdateComplete
    Last Transition Time:  2025-04-03T22:09:55Z
    Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: In desired config . Resumed normal operations.
    Reason:                Resumed
    Status:                False
    Type:                  Resumed
    Last Transition Time:  2025-04-03T22:08:41Z
    Message:               This node has not yet entered the Drained phase
    Reason:                NotYetOccurred
    Status:                False
    Type:                  Drained
    Last Transition Time:  2025-04-03T22:08:41Z
    Message:               This node has not yet entered the AppliedFilesAndOS phase
    Reason:                NotYetOccurred
    Status:                False
    Type:                  AppliedFilesAndOS
    Last Transition Time:  2025-04-03T22:08:41Z
    Message:               This node has not yet entered the Cordoned phase
    Reason:                NotYetOccurred
    Status:                False
    Type:                  Cordoned
    Last Transition Time:  2025-04-03T22:08:41Z
    Message:               This node has not yet entered the RebootedNode phase
    Reason:                NotYetOccurred
    Status:                False
    Type:                  RebootedNode
    Last Transition Time:  2025-04-03T22:09:55Z
    Message:               Node ip-10-0-110-176.us-west-2.compute.internal Updated
    Reason:                Updated
    Status:                True
    Type:                  Updated
    Last Transition Time:  2025-04-03T22:09:55Z
    Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: UnCordoned node. The node is reporting Unschedulable = false
    Reason:                UpdateCompleteUncordoned
    Status:                False
    Type:                  Uncordoned
    Last Transition Time:  2025-04-03T22:08:41Z
    Message:               All is good
    Reason:                AsExpected
    Status:                False
    Type:                  PinnedImageSetsDegraded
  Config Version:
    Current:            rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
    Desired:            rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
  Observed Generation:  3
Events:                 <none>

3. Apply a valid MC and watch the MCN object throughout the update to see MachineConfigNodeUpdateRebooted as a parent phase.

Before the update

    Last Transition Time:  2025-04-03T22:08:12Z
    Message:               This node has not yet entered the RebootedNode phase
    Reason:                NotYetOccurred
    Status:                False
    Type:                  RebootedNode

During the reboot

    Message:               Upgrade requires a reboot.
    Reason:                RebootedNode
    Status:                Unknown
    Type:                  RebootedNode

After successful reboot

    Message:               Node has rebooted
    Reason:                RebootedNode
    Status:                True
    Type:                  RebootedNode

4. Apply an invalid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
  name: test-pinned
  labels:
    machineconfiguration.openshift.io/role: "worker"
spec:
  pinnedImages:
   - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
   - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

The error message in the PinnedImageSetsDegraded MCN conditions and PIS status reference should now be a generalized message and the LastFailedGenerationErrors field should now be a string type field called LastFailedGenerationError.

$ oc describe machineconfignode ip-10-0-36-180.us-east-2.compute.internal
...
Status:
  Conditions:
    Last Transition Time:  2025-04-03T12:27:06Z
    Message:               node is prefetching images: ip-10-0-36-180.us-east-2.compute.internal
    Reason:                ImagePrefetch
    Status:                True
    Type:                  PinnedImageSetsProgressing
...
    Last Transition Time:  2025-04-03T12:27:07Z
    Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
    Reason:                PrefetchFailed
    Status:                True
    Type:                  PinnedImageSetsDegraded
...
Pinned Image Sets:
    Desired Generation:            2
    Last Failed Generation:        2
    Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
    Name:                          test-pinned

5. Apply a valid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
  name: test-pinned
  labels:
    machineconfiguration.openshift.io/role: "worker"
spec:
  pinnedImages:
   - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
   - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

The MCN conditions and PIS status reference should report as before.
Note that the new MCN API validation requires that LastFailedGenerationError is populated when a LastFailedGeneration value is reported. Since the default LastFailedGeneration of 0 always showed on a successful PIS application (as tested in cluster version 4.19.0-0.nightly-arm64-2025-03-21-080021), an empty string for LastFailedGenerationError is now also being reported. This will not be fixed in this PR as it is a result of an existing bug (see OCPBUG-54592).

...
Status:
  Conditions:
    Last Transition Time:  2025-04-03T11:53:06Z
    Message:               All pinned image sets complete
    Reason:                AsExpected
    Status:                False
    Type:                  PinnedImageSetsProgressing
...
    Last Transition Time:  2025-04-03T11:53:06Z
    Message:               All is good
    Reason:                AsExpected
    Status:                False
    Type:                  PinnedImageSetsDegraded
...
  Pinned Image Sets:
    Current Generation:            1
    Desired Generation:            1
    Last Failed Generation:        0
    Last Failed Generation Error:  
    Name:                          test-pinned
...

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201
  • Client-go bump pulls in changes from MCO-1544: API bump for MCN updates client-go#317
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.

- How to verify it
Launch cluster with this code in tech preview & observe updated fields in MCN objects.

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201
  • Client-go bump pulls in changes from MCO-1544: API bump for MCN updates client-go#317
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.
   UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201
  • Client-go bump pulls in changes from MCO-1544: API bump for MCN updates client-go#317
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.

• UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201
  • Client-go bump pulls in changes from MCO-1544: API bump for MCN updates client-go#317
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.

• UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

• The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-21-192.ec2.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T16:01:49Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-21-192.ec2.internal
   UID:             f5db5ed9-70f7-4e53-8e8c-934f8af55a42
 Resource Version:  18523
 UID:               4f9a956a-1ed9-4a1b-bbb0-5955c59c0570
Spec:
 Config Version:
   Desired:  rendered-worker-7123333eae329450f3da4a71e20ea7ee
 Node:
   Name:  ip-10-0-21-192.ec2.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdateCompatible phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateCompatible
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the ReloadedCRIO phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  ReloadedCRIO
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Node ip-10-0-21-192.ec2.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
 Config Version:
   Current:            rendered-worker-7123333eae329450f3da4a71e20ea7ee
   Desired:            rendered-worker-7123333eae329450f3da4a71e20ea7ee
 Observed Generation:  3
Events:                 <none>

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201
  • Client-go bump pulls in changes from MCO-1544: API bump for MCN updates client-go#317
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.

• UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

• The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-21-192.ec2.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T16:01:49Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-21-192.ec2.internal
   UID:             f5db5ed9-70f7-4e53-8e8c-934f8af55a42
 Resource Version:  18523
 UID:               4f9a956a-1ed9-4a1b-bbb0-5955c59c0570
Spec:
 Config Version:
   Desired:  rendered-worker-7123333eae329450f3da4a71e20ea7ee
 Node:
   Name:  ip-10-0-21-192.ec2.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdateCompatible phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateCompatible
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the ReloadedCRIO phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  ReloadedCRIO
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Node ip-10-0-21-192.ec2.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
 Config Version:
   Current:            rendered-worker-7123333eae329450f3da4a71e20ea7ee
   Desired:            rendered-worker-7123333eae329450f3da4a71e20ea7ee
 Observed Generation:  3
Events:                 <none>

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201
  • Client-go bump pulls in changes from MCO-1544: API bump for MCN updates client-go#317
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-21-192.ec2.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T16:01:49Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-21-192.ec2.internal
   UID:             f5db5ed9-70f7-4e53-8e8c-934f8af55a42
 Resource Version:  18523
 UID:               4f9a956a-1ed9-4a1b-bbb0-5955c59c0570
Spec:
 Config Version:
   Desired:  rendered-worker-7123333eae329450f3da4a71e20ea7ee
 Node:
   Name:  ip-10-0-21-192.ec2.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdateCompatible phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateCompatible
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the ReloadedCRIO phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  ReloadedCRIO
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Node ip-10-0-21-192.ec2.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
 Config Version:
   Current:            rendered-worker-7123333eae329450f3da4a71e20ea7ee
   Desired:            rendered-worker-7123333eae329450f3da4a71e20ea7ee
 Observed Generation:  3
Events:                 <none>

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201
  • Client-go bump pulls in changes from MCO-1544: API bump for MCN updates client-go#317
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-21-192.ec2.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T16:01:49Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-21-192.ec2.internal
   UID:             f5db5ed9-70f7-4e53-8e8c-934f8af55a42
 Resource Version:  18523
 UID:               4f9a956a-1ed9-4a1b-bbb0-5955c59c0570
Spec:
 Config Version:
   Desired:  rendered-worker-7123333eae329450f3da4a71e20ea7ee
 Node:
   Name:  ip-10-0-21-192.ec2.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the UpdateCompatible phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateCompatible
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               This node has not yet entered the ReloadedCRIO phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  ReloadedCRIO
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Node ip-10-0-21-192.ec2.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T16:02:56Z
   Message:               Action during update to rendered-worker-7123333eae329450f3da4a71e20ea7ee: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T16:01:57Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
 Config Version:
   Current:            rendered-worker-7123333eae329450f3da4a71e20ea7ee
   Desired:            rendered-worker-7123333eae329450f3da4a71e20ea7ee
 Observed Generation:  3
Events:                 <none>

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201
  • Client-go bump pulls in changes from MCO-1544: API bump for MCN updates client-go#317
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-5-15.us-west-1.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T19:27:51Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-5-15.us-west-1.compute.internal
   UID:             33658233-b500-46f2-a488-0c017fb4918e
 Resource Version:  26919
 UID:               bf38d7f7-9b19-4c70-86bc-b9646daee606
Spec:
 Config Version:
   Desired:  rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Node:
   Name:  ip-10-0-5-15.us-west-1.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Node ip-10-0-5-15.us-west-1.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsDegraded phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsDegraded
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsProgressing phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsProgressing
 Config Version:
   Current:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
   Desired:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Observed Generation:  3
Events:                 <none>

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201
  • Client-go bump pulls in changes from MCO-1544: API bump for MCN updates client-go#317
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                        POOLNAME    DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-5-15.us-west-1.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T19:27:51Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-5-15.us-west-1.compute.internal
   UID:             33658233-b500-46f2-a488-0c017fb4918e
 Resource Version:  26919
 UID:               bf38d7f7-9b19-4c70-86bc-b9646daee606
Spec:
 Config Version:
   Desired:  rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Node:
   Name:  ip-10-0-5-15.us-west-1.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Node ip-10-0-5-15.us-west-1.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsDegraded phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsDegraded
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsProgressing phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsProgressing
 Config Version:
   Current:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
   Desired:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Observed Generation:  3
Events:                 <none>

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201
  • Client-go bump pulls in changes from MCO-1544: API bump for MCN updates client-go#317
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-5-15.us-west-1.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T19:27:51Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-5-15.us-west-1.compute.internal
   UID:             33658233-b500-46f2-a488-0c017fb4918e
 Resource Version:  26919
 UID:               bf38d7f7-9b19-4c70-86bc-b9646daee606
Spec:
 Config Version:
   Desired:  rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Node:
   Name:  ip-10-0-5-15.us-west-1.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Node ip-10-0-5-15.us-west-1.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsDegraded phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsDegraded
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsProgressing phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsProgressing
 Config Version:
   Current:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
   Desired:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Observed Generation:  3
Events:                 <none>

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[RishabhSaini]

@isabella-janssen you would need to remove this as well since the MCN.Spec.PIS does not exist anymore:
https://github.com/openshift/machine-config-operator/pull/4962/files#diff-be61a7dfe9d23b169ca1c6cba268550fbfd3146163faaebafa3635bd3f759f27L1178-R1181

func getPinnedImageSetSpecForPools(pools []*mcfgv1.MachineConfigPool) []mcfgv1alpha1.MachineConfigNodeSpecPinnedImageSet {

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-5-15.us-west-1.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T19:27:51Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-5-15.us-west-1.compute.internal
   UID:             33658233-b500-46f2-a488-0c017fb4918e
 Resource Version:  26919
 UID:               bf38d7f7-9b19-4c70-86bc-b9646daee606
Spec:
 Config Version:
   Desired:  rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Node:
   Name:  ip-10-0-5-15.us-west-1.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Node ip-10-0-5-15.us-west-1.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsDegraded phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsDegraded
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsProgressing phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsProgressing
 Config Version:
   Current:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
   Desired:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Observed Generation:  3
Events:                 <none>

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code with tech preview enabled. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-5-15.us-west-1.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T19:27:51Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-5-15.us-west-1.compute.internal
   UID:             33658233-b500-46f2-a488-0c017fb4918e
 Resource Version:  26919
 UID:               bf38d7f7-9b19-4c70-86bc-b9646daee606
Spec:
 Config Version:
   Desired:  rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Node:
   Name:  ip-10-0-5-15.us-west-1.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Node ip-10-0-5-15.us-west-1.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsDegraded phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsDegraded
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsProgressing phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsProgressing
 Config Version:
   Current:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
   Desired:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Observed Generation:  3
Events:                 <none>

3. Apply an invalid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

The error message in the PinnedImageSetsDegraded MCN conditions and PIS status reference should report as before.

$ oc describe machineconfignode ip-10-0-36-180.us-east-2.compute.internal
...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T12:27:06Z
   Message:               node is prefetching images: ip-10-0-36-180.us-east-2.compute.internal
   Reason:                ImagePrefetch
   Status:                True
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T12:27:07Z
   Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
   Reason:                PrefetchFailed
   Status:                True
   Type:                  PinnedImageSetsDegraded
...
Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned

4. Apply a valid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

The MCN conditions and PIS status reference should report as before.

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code and the API code part of MCO-1630: Generate v1 crds for PIS api#2257 with tech preview enabled. Note that the API PR version is needed due to the v1 CRD deployments. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962,openshift/api#2257 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-5-15.us-west-1.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T19:27:51Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-5-15.us-west-1.compute.internal
   UID:             33658233-b500-46f2-a488-0c017fb4918e
 Resource Version:  26919
 UID:               bf38d7f7-9b19-4c70-86bc-b9646daee606
Spec:
 Config Version:
   Desired:  rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Node:
   Name:  ip-10-0-5-15.us-west-1.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Node ip-10-0-5-15.us-west-1.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsDegraded phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsDegraded
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsProgressing phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsProgressing
 Config Version:
   Current:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
   Desired:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Observed Generation:  3
Events:                 <none>

3. Apply an invalid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

The error message in the PinnedImageSetsDegraded MCN conditions and PIS status reference should report as before.

$ oc describe machineconfignode ip-10-0-36-180.us-east-2.compute.internal
...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T12:27:06Z
   Message:               node is prefetching images: ip-10-0-36-180.us-east-2.compute.internal
   Reason:                ImagePrefetch
   Status:                True
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T12:27:07Z
   Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
   Reason:                PrefetchFailed
   Status:                True
   Type:                  PinnedImageSetsDegraded
...
Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned

4. Apply a valid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

The MCN conditions and PIS status reference should report as before.

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code and the API code part of MCO-1630: Generate v1 crds for PIS api#2257 with tech preview enabled. Note that the API PR version is needed due to the v1 CRD deployments. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962,openshift/api#2257 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-5-15.us-west-1.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T19:27:51Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-5-15.us-west-1.compute.internal
   UID:             33658233-b500-46f2-a488-0c017fb4918e
 Resource Version:  26919
 UID:               bf38d7f7-9b19-4c70-86bc-b9646daee606
Spec:
 Config Version:
   Desired:  rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Node:
   Name:  ip-10-0-5-15.us-west-1.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Node ip-10-0-5-15.us-west-1.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsDegraded phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsDegraded
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsProgressing phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsProgressing
 Config Version:
   Current:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
   Desired:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Observed Generation:  3
Events:                 <none>

3. Apply an invalid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

The error message in the PinnedImageSetsDegraded MCN conditions and PIS status reference should now be a generalized message and the LastFailedGenerationErrors field should now be a string type field called LastFailedGenerationError.

$ oc describe machineconfignode ip-10-0-36-180.us-east-2.compute.internal
...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T12:27:06Z
   Message:               node is prefetching images: ip-10-0-36-180.us-east-2.compute.internal
   Reason:                ImagePrefetch
   Status:                True
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T12:27:07Z
   Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
   Reason:                PrefetchFailed
   Status:                True
   Type:                  PinnedImageSetsDegraded
...
Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned

4. Apply a valid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

The MCN conditions and PIS status reference should report as before.

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code and the API code part of MCO-1630: Generate v1 crds for PIS api#2257 with tech preview enabled. Note that the API PR version is needed due to the v1 CRD deployments. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962,openshift/api#2257 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-5-15.us-west-1.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T19:27:51Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-5-15.us-west-1.compute.internal
   UID:             33658233-b500-46f2-a488-0c017fb4918e
 Resource Version:  26919
 UID:               bf38d7f7-9b19-4c70-86bc-b9646daee606
Spec:
 Config Version:
   Desired:  rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Node:
   Name:  ip-10-0-5-15.us-west-1.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Node ip-10-0-5-15.us-west-1.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsDegraded phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsDegraded
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsProgressing phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsProgressing
 Config Version:
   Current:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
   Desired:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Observed Generation:  3
Events:                 <none>

3. Apply an invalid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

The error message in the PinnedImageSetsDegraded MCN conditions and PIS status reference should now be a generalized message and the LastFailedGenerationErrors field should now be a string type field called LastFailedGenerationError.

$ oc describe machineconfignode ip-10-0-36-180.us-east-2.compute.internal
...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T12:27:06Z
   Message:               node is prefetching images: ip-10-0-36-180.us-east-2.compute.internal
   Reason:                ImagePrefetch
   Status:                True
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T12:27:07Z
   Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
   Reason:                PrefetchFailed
   Status:                True
   Type:                  PinnedImageSetsDegraded
...
Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned

4. Apply a valid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

The MCN conditions and PIS status reference should report as before.
Note that the new MCN API validation requires that LastFailedGenerationError is populated when a LastFailedGeneration value is reported. Since the default LastFailedGeneration of 0 always showed on a successful PIS application (as tested in cluster version 4.19.0-0.nightly-arm64-2025-03-21-080021), an empty string for LastFailedGenerationError is now also being reported. This will not be fixed in this PR as it is a result of an existing bug (see OCPBUG-54592).

...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
...
 Pinned Image Sets:
   Current Generation:            1
   Desired Generation:            1
   Last Failed Generation:        0
   Last Failed Generation Error:  
   Name:                          test-pinned
...

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO:

• Add info about change to having MachineConfigNodeUpdateRebooted be a parent phase and how to test.
• Update the MCN enhancement to reflect the MachineConfigNodeUpdateRebooted change.

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code and the API code part of MCO-1630: Generate v1 crds for PIS api#2257 with tech preview enabled. Note that the API PR version is needed due to the v1 CRD deployments. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962,openshift/api#2257 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-5-15.us-west-1.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T19:27:51Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-5-15.us-west-1.compute.internal
   UID:             33658233-b500-46f2-a488-0c017fb4918e
 Resource Version:  26919
 UID:               bf38d7f7-9b19-4c70-86bc-b9646daee606
Spec:
 Config Version:
   Desired:  rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Node:
   Name:  ip-10-0-5-15.us-west-1.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Node ip-10-0-5-15.us-west-1.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsDegraded phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsDegraded
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsProgressing phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsProgressing
 Config Version:
   Current:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
   Desired:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Observed Generation:  3
Events:                 <none>

3. Apply an invalid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

The error message in the PinnedImageSetsDegraded MCN conditions and PIS status reference should now be a generalized message and the LastFailedGenerationErrors field should now be a string type field called LastFailedGenerationError.

$ oc describe machineconfignode ip-10-0-36-180.us-east-2.compute.internal
...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T12:27:06Z
   Message:               node is prefetching images: ip-10-0-36-180.us-east-2.compute.internal
   Reason:                ImagePrefetch
   Status:                True
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T12:27:07Z
   Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
   Reason:                PrefetchFailed
   Status:                True
   Type:                  PinnedImageSetsDegraded
...
Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned

4. Apply a valid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

The MCN conditions and PIS status reference should report as before.
Note that the new MCN API validation requires that LastFailedGenerationError is populated when a LastFailedGeneration value is reported. Since the default LastFailedGeneration of 0 always showed on a successful PIS application (as tested in cluster version 4.19.0-0.nightly-arm64-2025-03-21-080021), an empty string for LastFailedGenerationError is now also being reported. This will not be fixed in this PR as it is a result of an existing bug (see OCPBUG-54592).

...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
...
 Pinned Image Sets:
   Current Generation:            1
   Desired Generation:            1
   Last Failed Generation:        0
   Last Failed Generation Error:  
   Name:                          test-pinned
...

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO:

• Add info about change to having MachineConfigNodeUpdateRebooted be a parent phase and how to test.
• Update the MCN enhancement to reflect the MachineConfigNodeUpdateRebooted change.
• Squash commits

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code and the API code part of MCO-1630: Generate v1 crds for PIS api#2257 with tech preview enabled. Note that the API PR version is needed due to the v1 CRD deployments. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962,openshift/api#2257 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-21-192.ec2.internal
Name:         ip-10-0-5-15.us-west-1.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-03-31T19:27:51Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-5-15.us-west-1.compute.internal
   UID:             33658233-b500-46f2-a488-0c017fb4918e
 Resource Version:  26919
 UID:               bf38d7f7-9b19-4c70-86bc-b9646daee606
Spec:
 Config Version:
   Desired:  rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Node:
   Name:  ip-10-0-5-15.us-west-1.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Node ip-10-0-5-15.us-west-1.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-03-31T19:28:21Z
   Message:               Action during update to rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsDegraded phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsDegraded
   Last Transition Time:  2025-03-31T19:28:11Z
   Message:               This node has not yet entered the PinnedImageSetsProgressing phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  PinnedImageSetsProgressing
 Config Version:
   Current:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
   Desired:            rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99
 Observed Generation:  3
Events:                 <none>

3. Apply an invalid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

The error message in the PinnedImageSetsDegraded MCN conditions and PIS status reference should now be a generalized message and the LastFailedGenerationErrors field should now be a string type field called LastFailedGenerationError.

$ oc describe machineconfignode ip-10-0-36-180.us-east-2.compute.internal
...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T12:27:06Z
   Message:               node is prefetching images: ip-10-0-36-180.us-east-2.compute.internal
   Reason:                ImagePrefetch
   Status:                True
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T12:27:07Z
   Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
   Reason:                PrefetchFailed
   Status:                True
   Type:                  PinnedImageSetsDegraded
...
Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned

4. Apply a valid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

The MCN conditions and PIS status reference should report as before.
Note that the new MCN API validation requires that LastFailedGenerationError is populated when a LastFailedGeneration value is reported. Since the default LastFailedGeneration of 0 always showed on a successful PIS application (as tested in cluster version 4.19.0-0.nightly-arm64-2025-03-21-080021), an empty string for LastFailedGenerationError is now also being reported. This will not be fixed in this PR as it is a result of an existing bug (see OCPBUG-54592).

...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
...
 Pinned Image Sets:
   Current Generation:            1
   Desired Generation:            1
   Last Failed Generation:        0
   Last Failed Generation Error:  
   Name:                          test-pinned
...

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO:

• Add info about change to having MachineConfigNodeUpdateRebooted be a parent phase and how to test.
• Update the MCN enhancement to reflect the MachineConfigNodeUpdateRebooted change.
• Squash commits

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code and the API code part of MCO-1630: Generate v1 crds for PIS api#2257 with tech preview enabled. Note that the API PR version is needed due to the v1 CRD deployments. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962,openshift/api#2257 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-110-176.us-west-2.compute.internal
Name:         ip-10-0-110-176.us-west-2.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-04-03T22:08:41Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-110-176.us-west-2.compute.internal
   UID:             f3d946e9-24d4-4b96-b4a7-4536d79c73a8
 Resource Version:  18006
 UID:               7f03657f-d52a-4a48-b835-370f22fc773a
Spec:
 Config Version:
   Desired:  rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
 Node:
   Name:  ip-10-0-110-176.us-west-2.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Node ip-10-0-110-176.us-west-2.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
 Config Version:
   Current:            rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
   Desired:            rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
 Observed Generation:  3
Events:                 <none>

3. Apply a valid MC and watch the MCN object throughout the update to see MachineConfigNodeUpdateRebooted as a parent phase.

Before the update

   Last Transition Time:  2025-04-03T22:08:12Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode

During the reboot

   Message:               Upgrade requires a reboot.
   Reason:                RebootedNode
   Status:                Unknown
   Type:                  RebootedNode

After successful reboot

   Message:               Node has rebooted
   Reason:                RebootedNode
   Status:                True
   Type:                  RebootedNode

4. Apply an invalid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

The error message in the PinnedImageSetsDegraded MCN conditions and PIS status reference should now be a generalized message and the LastFailedGenerationErrors field should now be a string type field called LastFailedGenerationError.

$ oc describe machineconfignode ip-10-0-36-180.us-east-2.compute.internal
...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T12:27:06Z
   Message:               node is prefetching images: ip-10-0-36-180.us-east-2.compute.internal
   Reason:                ImagePrefetch
   Status:                True
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T12:27:07Z
   Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
   Reason:                PrefetchFailed
   Status:                True
   Type:                  PinnedImageSetsDegraded
...
Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned

5. Apply a valid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

The MCN conditions and PIS status reference should report as before.
Note that the new MCN API validation requires that LastFailedGenerationError is populated when a LastFailedGeneration value is reported. Since the default LastFailedGeneration of 0 always showed on a successful PIS application (as tested in cluster version 4.19.0-0.nightly-arm64-2025-03-21-080021), an empty string for LastFailedGenerationError is now also being reported. This will not be fixed in this PR as it is a result of an existing bug (see OCPBUG-54592).

...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
...
 Pinned Image Sets:
   Current Generation:            1
   Desired Generation:            1
   Last Failed Generation:        0
   Last Failed Generation Error:  
   Name:                          test-pinned
...

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO:

• Add info about change to having MachineConfigNodeUpdateRebooted be a parent phase and how to test.
• Update the MCN enhancement to reflect the MachineConfigNodeUpdateRebooted change.
• Squash commits

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code and the API code part of MCO-1630: Generate v1 crds for PIS api#2257 with tech preview enabled. Note that the API PR version is needed due to the v1 CRD deployments. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962,openshift/api#2257 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-110-176.us-west-2.compute.internal
Name:         ip-10-0-110-176.us-west-2.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-04-03T22:08:41Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-110-176.us-west-2.compute.internal
   UID:             f3d946e9-24d4-4b96-b4a7-4536d79c73a8
 Resource Version:  18006
 UID:               7f03657f-d52a-4a48-b835-370f22fc773a
Spec:
 Config Version:
   Desired:  rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
 Node:
   Name:  ip-10-0-110-176.us-west-2.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Node ip-10-0-110-176.us-west-2.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
 Config Version:
   Current:            rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
   Desired:            rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
 Observed Generation:  3
Events:                 <none>

3. Apply a valid MC and watch the MCN object throughout the update to see MachineConfigNodeUpdateRebooted as a parent phase.

Before the update

   Last Transition Time:  2025-04-03T22:08:12Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode

During the reboot

   Message:               Upgrade requires a reboot.
   Reason:                RebootedNode
   Status:                Unknown
   Type:                  RebootedNode

After successful reboot

   Message:               Node has rebooted
   Reason:                RebootedNode
   Status:                True
   Type:                  RebootedNode

4. Apply an invalid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

The error message in the PinnedImageSetsDegraded MCN conditions and PIS status reference should now be a generalized message and the LastFailedGenerationErrors field should now be a string type field called LastFailedGenerationError.

$ oc describe machineconfignode ip-10-0-36-180.us-east-2.compute.internal
...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T12:27:06Z
   Message:               node is prefetching images: ip-10-0-36-180.us-east-2.compute.internal
   Reason:                ImagePrefetch
   Status:                True
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T12:27:07Z
   Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
   Reason:                PrefetchFailed
   Status:                True
   Type:                  PinnedImageSetsDegraded
...
Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned

5. Apply a valid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

The MCN conditions and PIS status reference should report as before.
Note that the new MCN API validation requires that LastFailedGenerationError is populated when a LastFailedGeneration value is reported. Since the default LastFailedGeneration of 0 always showed on a successful PIS application (as tested in cluster version 4.19.0-0.nightly-arm64-2025-03-21-080021), an empty string for LastFailedGenerationError is now also being reported. This will not be fixed in this PR as it is a result of an existing bug (see OCPBUG-54592).

...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
...
 Pinned Image Sets:
   Current Generation:            1
   Desired Generation:            1
   Last Failed Generation:        0
   Last Failed Generation Error:  
   Name:                          test-pinned
...

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change	722b214	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/unit	722b214	link	true	/test unit
ci/prow/bootstrap-unit	722b214	link	false	/test bootstrap-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

• Version bumps
  • API bump pulls in changes from MCO-1543: Update v1alpha1 MCN API api#2201 & NO ISSUE: Tombstone Spec.PinnedImageSets in MCN v1alpha1 API api#2256
  • Client-go bump pulls in changes from NO ISSUE: API bump for MCN updates client-go#318
• Pull in changes made to the MCN API.
  • Remove references to statuses MachineConfigNodeUpdateCompatible and MachineConfigNodeUpdateReloaded.
  • Remove references to LastFailedGenerationErrors field. Add new LastFailedGenerationError field.
  • Generalize the message when MachineConfigNodePinnedImageSetsDegraded condition is True.
  • Remove unused getPinnedImageSetSpecForPools function to cleanup remaining MachineConfigNodeSpecPinnedImageSet references.

- How to verify it

1. Launch 4.19 cluster with this code and the API code part of MCO-1630: Generate v1 crds for PIS api#2257 with tech preview enabled. Note that the API PR version is needed due to the v1 CRD deployments. Using ClusterBot, an example launch command is:

launch 4.19,openshift/machine-config-operator#4962,openshift/api#2257 aws,techpreview

2. Observe updated fields in MCN objects.

UPDATECOMPATIBLE and REBOOTEDNODE should not be in the output of oc get machineconfignode -o wide.

$ oc get machineconfignode -o wide
NAME                                         POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-125-181.us-west-1.compute.internal   master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-29-132.us-west-1.compute.internal    master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-5-15.us-west-1.compute.internal      worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-235.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-59-8.us-west-1.compute.internal      master     rendered-master-d51baee5aae85f41def583ae900f00d3   rendered-master-d51baee5aae85f41def583ae900f00d3   True      False            False            False                      False            False     False               False          False         False          False
ip-10-0-92-170.us-west-1.compute.internal    worker     rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   rendered-worker-1ddf0545a57e0ea7eaebd1fb6a15bc99   True      False            False            False                      False            False     False               False          False         False          False

The conditions list of a MachineConfigNode should not include items with type UpdateCompatible or ReloadedCRIO.

$ oc describe machineconfignode/ip-10-0-110-176.us-west-2.compute.internal
Name:         ip-10-0-110-176.us-west-2.compute.internal
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  machineconfiguration.openshift.io/v1alpha1
Kind:         MachineConfigNode
Metadata:
 Creation Timestamp:  2025-04-03T22:08:41Z
 Generation:          2
 Owner References:
   API Version:     v1
   Kind:            Node
   Name:            ip-10-0-110-176.us-west-2.compute.internal
   UID:             f3d946e9-24d4-4b96-b4a7-4536d79c73a8
 Resource Version:  18006
 UID:               7f03657f-d52a-4a48-b835-370f22fc773a
Spec:
 Config Version:
   Desired:  rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
 Node:
   Name:  ip-10-0-110-176.us-west-2.compute.internal
 Pool:
   Name:  worker
Status:
 Conditions:
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the UpdatePrepared phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePrepared
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the UpdateExecuted phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdateExecuted
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the UpdatePostActionComplete phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  UpdatePostActionComplete
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: Uncordoned Node as part of completing upgrade phase
   Reason:                Uncordoned
   Status:                False
   Type:                  UpdateComplete
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: In desired config . Resumed normal operations.
   Reason:                Resumed
   Status:                False
   Type:                  Resumed
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the Drained phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Drained
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the AppliedFilesAndOS phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  AppliedFilesAndOS
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the Cordoned phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  Cordoned
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Node ip-10-0-110-176.us-west-2.compute.internal Updated
   Reason:                Updated
   Status:                True
   Type:                  Updated
   Last Transition Time:  2025-04-03T22:09:55Z
   Message:               Action during update to rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb: UnCordoned node. The node is reporting Unschedulable = false
   Reason:                UpdateCompleteUncordoned
   Status:                False
   Type:                  Uncordoned
   Last Transition Time:  2025-04-03T22:08:41Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
 Config Version:
   Current:            rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
   Desired:            rendered-worker-8c82b2aa30e5b7d400201f40ebd660fb
 Observed Generation:  3
Events:                 <none>

3. Apply a valid MC and watch the MCN object throughout the update to see MachineConfigNodeUpdateRebooted as a parent phase.

Before the update

   Last Transition Time:  2025-04-03T22:08:12Z
   Message:               This node has not yet entered the RebootedNode phase
   Reason:                NotYetOccurred
   Status:                False
   Type:                  RebootedNode

During the reboot

   Message:               Upgrade requires a reboot.
   Reason:                RebootedNode
   Status:                Unknown
   Type:                  RebootedNode

After successful reboot

   Message:               Node has rebooted
   Reason:                RebootedNode
   Status:                True
   Type:                  RebootedNode

4. Apply an invalid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

The error message in the PinnedImageSetsDegraded MCN conditions and PIS status reference should now be a generalized message and the LastFailedGenerationErrors field should now be a string type field called LastFailedGenerationError.

$ oc describe machineconfignode ip-10-0-36-180.us-east-2.compute.internal
...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T12:27:06Z
   Message:               node is prefetching images: ip-10-0-36-180.us-east-2.compute.internal
   Reason:                ImagePrefetch
   Status:                True
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T12:27:07Z
   Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
   Reason:                PrefetchFailed
   Status:                True
   Type:                  PinnedImageSetsDegraded
...
Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned

5. Apply a valid PIS, such as the one below.

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

The MCN conditions and PIS status reference should report as before.
Note that the new MCN API validation requires that LastFailedGenerationError is populated when a LastFailedGeneration value is reported. Since the default LastFailedGeneration of 0 always showed on a successful PIS application (as tested in cluster version 4.19.0-0.nightly-arm64-2025-03-21-080021), an empty string for LastFailedGenerationError is now also being reported. This will not be fixed in this PR as it is a result of an existing bug (see OCPBUG-54592).

...
Status:
 Conditions:
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All pinned image sets complete
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsProgressing
...
   Last Transition Time:  2025-04-03T11:53:06Z
   Message:               All is good
   Reason:                AsExpected
   Status:                False
   Type:                  PinnedImageSetsDegraded
...
 Pinned Image Sets:
   Current Generation:            1
   Desired Generation:            1
   Last Failed Generation:        0
   Last Failed Generation Error:  
   Name:                          test-pinned
...

- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

Overall looks good to me, thanks for the fixups!

Will do final lgtm tag after pre merge QE testing

/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [djoshy,isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment