OCPQE-27708 - Annotationtestsgcp

[miyadav]

Adding annotation tests on gcp . This is work in progress , any suggestions are welcome.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[miyadav]

once PR is merged the new added test shall pass .

[sunzhaohua2]

@miyadav Thanks for working on this, it might be better if we could check result from gcp cli，or we dont know if it take affect. Takecloud.google.com/network-tier annotationfor example, the step may be:

1. create service with annotation cloud.google.com/network-tier: Standard
2. check with gcp cli that LB with network-tier: Standard
3. update service annotation to network-tier: Premium
4. check with gcp cli that LB with network-tier: Premium
5. remove the annoation
6. check with gcp cli that LB with network-tier: Standard
7. create with invalidvalue
8. check create failed

[sunzhaohua2]

maybe set namespace as const and change to another namespace.

[sunzhaohua2]

return "", fmt.Errorf("failed to get service: %v", err)

[sunzhaohua2]

o.Expect(cl.Update(ctx, latestService)).To(o.Succeed(), "Failed to update service with annotation")

[miyadav]

@miyadav Thanks for working on this, it might be better if we could check result from gcp cli，or we dont know if it take affect. Takecloud.google.com/network-tier annotationfor example, the step may be:

1. create service with annotation cloud.google.com/network-tier: Standard
2. check with gcp cli that LB with network-tier: Standard
3. update service annotation to network-tier: Premium
4. check with gcp cli that LB with network-tier: Premium
5. remove the annoation
6. check with gcp cli that LB with network-tier: Standard
7. create with invalidvalue
8. check create failed

We are checking the updated IP ( line 136 to confirm it took effect .
I will review more for the updates to confirm from cli.

[miyadav]

@miyadav Thanks for working on this, it might be better if we could check result from gcp cli，or we dont know if it take affect. Takecloud.google.com/network-tier annotationfor example, the step may be:

1. create service with annotation cloud.google.com/network-tier: Standard
2. check with gcp cli that LB with network-tier: Standard
3. update service annotation to network-tier: Premium
4. check with gcp cli that LB with network-tier: Premium
5. remove the annoation
6. check with gcp cli that LB with network-tier: Standard
7. create with invalidvalue
8. check create failed

I am not sure how to use gcp cli , do you think something like below , I try running it seeing some issues , not sure if this is helpful as well , we would be required to know many details in such case and would be too deep into networking 🤔

`func verifyGCPAnnotation(svcName, annotation, expectedValue string) bool {
	var cmd string

	switch annotation {
	case "cloud.google.com/network-tier":
		cmd = fmt.Sprintf("gcloud compute forwarding-rules describe %s --format='value(networkTier)'", svcName)
	case "networking.gke.io/internal-load-balancer-allow-global-access":
		cmd = fmt.Sprintf("gcloud compute forwarding-rules describe %s --format='value(allowGlobalAccess)'", svcName)
	case "alpha.cloud.google.com/load-balancer-backend-share":
		cmd = fmt.Sprintf("gcloud compute backend-services describe %s --format='value(backendShare)'", svcName)
	default:
		fmt.Println("No GCP CLI validation available for annotation:", annotation)
		return true
	}`

[openshift-ci]

@miyadav: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-operator	aa15c8b	link	false	/test e2e-openstack-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[miyadav]

/test e2e-gcp-operator