Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-2213: Expose the /federate endpoint of UWM Prometheus as a route #1633

Merged
merged 1 commit into from
Apr 25, 2022
Merged

MON-2213: Expose the /federate endpoint of UWM Prometheus as a route #1633

merged 1 commit into from
Apr 25, 2022

Conversation

arajkumar
Copy link
Contributor

@arajkumar arajkumar commented Apr 11, 2022 •
edited
Loading

Successor of #1601 to expose UWM federate service as a Openshift Route.

Signed-off-by: Arunprasad Rajkumar [email protected]

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2022
@openshift-ci openshift-ci bot requested review from simonpasquier and sthaha April 11, 2022 13:13
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2022
@arajkumar
Copy link
Contributor Author

/test all

@arajkumar arajkumar force-pushed the route-for-uwm-prometheus branch from 8a27df5 to 6f12b73 Compare April 12, 2022 02:28
@arajkumar arajkumar marked this pull request as ready for review April 12, 2022 04:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2022
@arajkumar arajkumar marked this pull request as draft April 12, 2022 05:26
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2022
@arajkumar arajkumar force-pushed the route-for-uwm-prometheus branch from 6f12b73 to f8ca17b Compare April 12, 2022 07:18
arajkumar
arajkumar commented Apr 12, 2022
View reviewed changes
@arajkumar arajkumar force-pushed the route-for-uwm-prometheus branch from f8ca17b to 14d6a82 Compare April 12, 2022 07:30
@arajkumar
Copy link
Contributor Author

/test all

@arajkumar arajkumar marked this pull request as ready for review April 12, 2022 09:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2022
@arajkumar arajkumar force-pushed the route-for-uwm-prometheus branch from 14d6a82 to 8671d2c Compare April 12, 2022 10:31
@arajkumar
Copy link
Contributor Author

Ping @juzhao for qe approval.
Ping @Senthamilarasu-STA (for px-approval)

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2022
@arajkumar arajkumar force-pushed the route-for-uwm-prometheus branch from 8671d2c to 6d3acbc Compare April 12, 2022 14:54
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2022
@juzhao
Copy link
Contributor

juzhao commented Apr 14, 2022

@lihongyan1 please help to review

@lihongyan1
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 15, 2022
simonpasquier
simonpasquier reviewed Apr 15, 2022
View reviewed changes
test/e2e/user_workload_monitoring_test.go Outdated

b, err := ioutil.ReadAll(resp.Body)
r, err := factory.PrometheusUserWorkloadFederateRoute()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we didn't couple the e2e test with the manifests package since this has been the approach so far. In practice, the test should assume the name of the route.

assets/prometheus-user-workload/federate-route.yaml Outdated
metadata:
labels:
app.kubernetes.io/part-of: openshift-monitoring
name: prometheus-uwm-federate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: prometheus-uwm-federate
name: prometheus-user-workload-federate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonpasquier , Route with name prometheus-user-workload-federate causes the following error due to long name.

 Updating Prometheus-user-workload failed: reconciling UserWorkload federate Route failed: creating Route object failed: Route.route.openshift.io "prometheus-user-workload-federate" is invalid: spec.host: Invalid value: "prometheus-user-workload-federate-openshift-user-workload-monitoring.apps.ci-ln-53rm4lk-72292.origin-ci-int-gce.dev.rhcloud.com": must be no more than 63 characters

I guess we can stick to a simple name like federare as it is a sub domain of openshift-user-workload-monitoring.apps.ci-ln-53rm4lk-72292.origin-ci-int-gce.dev.rhcloud.com.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@arajkumar arajkumar force-pushed the route-for-uwm-prometheus branch from 2811be7 to fb83bf7 Compare April 19, 2022 12:06
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@simonpasquier
Copy link
Contributor

/test e2e-agnostic-operator
/skip
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@arajkumar arajkumar force-pushed the route-for-uwm-prometheus branch from fb83bf7 to 059955e Compare April 20, 2022 07:41
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2022
simonpasquier
simonpasquier reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2022
@arajkumar
Copy link
Contributor Author

/retest

@arajkumar
MON-2213: Expose the /federate endpoint of UWM Prometheus as a route
b647559 
Successor of openshift#1601 to expose UWM federate service as a Openshift Route.

Signed-off-by: Arunprasad Rajkumar <[email protected]>
@arajkumar arajkumar force-pushed the route-for-uwm-prometheus branch from 059955e to b647559 Compare April 20, 2022 10:08
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2022
@arajkumar
Copy link
Contributor Author

/skip
/test e2e-agnostic-upgrade

@arajkumar
Copy link
Contributor Author

/test e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2022

@arajkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node b647559 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

/lgtm
/label docs-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. labels Apr 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arajkumar, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [arajkumar,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lihongyan1
Copy link

/label qe-approved

@arajkumar
Copy link
Contributor Author

Ping @Senthamilarasu-STA for px-approval

@Senthamilarasu-STA
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit 95f04c1 into openshift:master Apr 25, 2022
@arajkumar arajkumar mentioned this pull request May 4, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@sthaha sthaha Awaiting requested review from sthaha

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

@raptorsun raptorsun Awaiting requested review from raptorsun

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arajkumar @juzhao @lihongyan1 @simonpasquier @openshift-bot @Senthamilarasu-STA @openshift-merge-robot