Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] OCPBUGS-52496,OCPBUGS-52494: Updates GCP credentials request #1341

Merged
merged 1 commit into from
Mar 12, 2025
Merged

[release-4.18] OCPBUGS-52496,OCPBUGS-52494: Updates GCP credentials request #1341

merged 1 commit into from
Mar 12, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1335

/assign theobarberbany

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14 release-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-51373 has been cloned as Jira Issue OCPBUGS-52496. Will retitle bug to link to clone.

Detected clone of Jira Issue OCPBUGS-44671 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.18] OCPBUGS-52496,OCPBUGS-52494: Updates GCP credentials request

In response to this:

This is an automated cherry-pick of #1335

/assign theobarberbany

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14 release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-51373,OCPBUGS-44671: Updates GCP credentials request [release-4.18] OCPBUGS-52496,OCPBUGS-52494: Updates GCP credentials request Mar 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 6, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-52496, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-52494, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1335

/assign theobarberbany

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14 release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 6, 2025
@openshift-ci openshift-ci bot requested review from damdo and sub-mod March 6, 2025 17:12
@theobarberbany
Updates GCP credentials request
6a916b1 
This change adds the compute.images.get and getFromFamily to the
credentials request for GCP. It is required by MAPG for checking if a
disk is UEFI compatible.

See openshift/machine-api-provider-gcp#108
@openshift-cherrypick-robot openshift-cherrypick-robot force-pushed the cherry-pick-1335-to-release-4.18 branch from 2297100 to 6a916b1 Compare March 6, 2025 17:49
@theobarberbany theobarberbany mentioned this pull request Mar 6, 2025
Merged
JoelSpeed
JoelSpeed reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 7, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2025
@sunzhaohua2
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 10, 2025
@damdo
Copy link
Member

damdo commented Mar 10, 2025

/assign @theobarberbany

@theobarberbany
Copy link
Contributor

/retest

@JoelSpeed
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@JoelSpeed: This pull request references Jira Issue OCPBUGS-52496, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-52494, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor

/test yaml-lint

@theobarberbany
Copy link
Contributor

/retest

@theobarberbany
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 12, 2025
@openshift-ci-robot
Copy link
Contributor

@theobarberbany: This pull request references Jira Issue OCPBUGS-52496, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-51373 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-51373 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

This pull request references Jira Issue OCPBUGS-52494, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-44671 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-44671 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 12, 2025
@openshift-ci openshift-ci bot requested a review from sunzhaohua2 March 12, 2025 13:01
@JoelSpeed
Copy link
Contributor

/override ci/prow/yaml-lint

I can't find the configuration for this status check

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/yaml-lint

In response to this:

/override ci/prow/yaml-lint

I can't find the configuration for this status check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-nutanix 6a916b1 link false /test e2e-nutanix

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9988949 into openshift:release-4.18 Mar 12, 2025
28 of 29 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-52496: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-52496 has not been moved to the MODIFIED state.

Jira Issue OCPBUGS-52494: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-52494 has not been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1335

/assign theobarberbany

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14 release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

@openshift-cherrypick-robot: new pull request created: #1345

In response to this:

This is an automated cherry-pick of #1335

/assign theobarberbany

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14 release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 12, 2025
Open
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.18.0-202503130333.p0.g9988949.assembly.stream.el9.
All builds following this will include this PR.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@damdo damdo Awaiting requested review from damdo

@sub-mod sub-mod Awaiting requested review from sub-mod

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

Assignees

@JoelSpeed JoelSpeed

@theobarberbany theobarberbany

@sunzhaohua2 sunzhaohua2

@miyadav miyadav

@huali9 huali9

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @sunzhaohua2 @damdo @theobarberbany @JoelSpeed @openshift-bot @miyadav @huali9