OCPBUGS-51373,OCPBUGS-44671: Updates GCP credentials request #1335
Conversation
This change adds the compute.images.get and getFromFamily to the credentials request for GCP. It is required by MAPG for checking if a disk is UEFI compatible. See openshift/machine-api-provider-gcp#108
theobarberbany
changed the title
|
/payload job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial |
|
@theobarberbany: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial |
|
@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/28db3f30-f50a-11ef-94c7-090ce508aedf-0 |
theobarberbany
changed the title
openshift-ci-robot
added
jira/severity-important
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-51373, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-44671, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-51373, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: This pull request references Jira Issue OCPBUGS-44671, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm Theo, feel free to release the hold if you're confident the tests pass Given the serial perma-failed, this should be pretty binary on if this fixes it or not |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
CI suggests this isn't actually fixing the issue, but I think this is the correct to merge still, even if it doesn't resolve the issue /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@theobarberbany: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 709f4c3
into
openshift:master
|
@theobarberbany: Jira Issue OCPBUGS-51373: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-51373 has been moved to the MODIFIED state. Jira Issue OCPBUGS-44671: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44671 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-api-operator |
|
/cherry-pick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14 release-4.13 |
|
@theobarberbany: new pull request created: #1341 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@theobarberbany: new pull request could not be created: failed to create pull request against openshift/machine-api-operator#release-4.18 from head openshift-cherrypick-robot:cherry-pick-1335-to-release-4.18: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-1335-to-release-4.18."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This change adds the compute.images.get and getFromFamily to the credentials request for GCP. It is required by MAPG for checking if a disk is UEFI compatible.
See openshift/machine-api-provider-gcp#108