Adds kopia/restic uploader type

[mpryc]

Implements #1101 part of the #1046

Testing instructions:

1. Uninstall previous version of OADP
2. Ensure you are logged as an admin

$ oc whoami
system:admin

4. Remove left over CRD's:

$ oc delete crd dataprotectionapplications.oadp.openshift.io volumesnapshotrestores.datamover.oadp.openshift.io volumesnapshotbackups.datamover.oadp.openshift.io cloudstorages.oadp.openshift.io

5a. You may want to use the following patch to not install or symlink podman to docker:

$ patch -p1 < /below/patch/file/location.diff

index 94cfa11..bf250a4 100644
--- a/Makefile
+++ b/Makefile
@@ -212,10 +212,10 @@ run: manifests generate fmt vet ## Run a controller from your host.
 # related enhancements that may remove the need to manually install qemu-user-static https://bugzilla.redhat.com/show_bug.cgi?id=2061584
 DOCKER_BUILD_ARGS ?= --platform=linux/amd64
 docker-build: ## Build docker image with the manager.
-	docker build -t $(IMG) . $(DOCKER_BUILD_ARGS)
+	podman build -t $(IMG) . $(DOCKER_BUILD_ARGS)
 
 docker-push: ## Push docker image with the manager.
-	docker push ${IMG}
+	podman push ${IMG}
 
 ##@ Deployment
 
@@ -361,7 +361,7 @@ nullable-crds-config:
 
 .PHONY: bundle-build
 bundle-build: ## Build the bundle image.
-	docker build -f bundle.Dockerfile -t $(BUNDLE_IMG) . $(DOCKER_BUILD_ARGS)
+	podman build -f bundle.Dockerfile -t $(BUNDLE_IMG) . $(DOCKER_BUILD_ARGS)
 
 .PHONY: bundle-push
 bundle-push: ## Push the bundle image.

5b. Build and deploy OADP from this PR:

$ make build-deploy
$ make deploy-olm

6. Create DPA, ensure to choose restic or kopia and ensure to use unsupportedOverrides with provided veleroImageFqin

Make sure to specify the backupLocations accordingly to your cluster configuration and s3 bucket

Part of the DPA for restic:

apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
  name: dpa-sample
spec:
  configuration:
    nodeAgentConfig:
      enable: true
      uploaderType: restic
[...]
  unsupportedOverrides:
    veleroImageFqin: 'docker.io/sseago/velero:kopia'

And for Kopia

apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
  name: dpa-sample
spec:
  configuration:
    nodeAgentConfig:
      enable: true
      uploaderType: kopia
[...]
  unsupportedOverrides:
    veleroImageFqin: 'docker.io/sseago/velero:kopia'

8. Create Backup object to trigger backup, ensure to include defaultVolumesToFsBackup: true

apiVersion: velero.io/v1
kind: Backup
metadata:
  name: mysql-persistent
  namespace: openshift-adp
spec:
  includedNamespaces:
  - mysql-persistent
  storageLocation: dpa-sample
  defaultVolumesToFsBackup: true
  ttl: 720h0m0s

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[sseago]

Looks like timeout isn't being set properly with nodeAgentConfig. If you add timeout to restic, it's pulled into the velero deployment, but if you add to nodeAgentConfig it's not. Here's where you need to check for nodeAgentConfig and then restic, rather than just restic:
https://github.com/openshift/oadp-operator/blob/master/controllers/velero.go#L429-L431

	if dpa.Spec.Configuration.Restic != nil && len(dpa.Spec.Configuration.Restic.Timeout) > 0 {
		fsBackupTimeout = dpa.Spec.Configuration.Restic.Timeout
	}

[sseago]

Other than the timeout config bug, I was able to successfully back up and restore the OADP mysql-persistent testing app with kopia fs backup using this PR.

[weshayutin]

@sseago nice! Thanks for testing mysql-persistent. If mysql db was successful w/ just a regular kopia backup then we have at least a data point to investigate https://issues.redhat.com/browse/OADP-2360 w/ kopia + DM. Thank you!

[sseago]

Looks good overall. One additional thing -- for final merge, it's better to remove code we don't want than just commenting it out.

[kaovilai]

Filed issue: vmware-tanzu/velero#6700

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kaovilai,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kaovilai]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3dbdc4e and 2 for PR HEAD c3e68cf in total

[openshift-ci]

@mpryc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.