Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-5799: Pass log format to NAC controller #1687

Conversation

shubham-pampattiwar
Copy link
Member

@shubham-pampattiwar shubham-pampattiwar commented Apr 1, 2025

Why the changes were made

Fixes https://issues.redhat.com/browse/OADP-5799
Depends on migtools/oadp-non-admin#260
Fixes migtools/oadp-non-admin#254

How to test the changes made

  • Try passing logFormat via DPA as json or text
  • Check the NAC deployment/Pod for the value of LOG_FORMAT env var
  • Finally, check the format of logs in NAC controller pod

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025

@shubham-pampattiwar: This pull request references OADP-5799 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Why the changes were made

Part of fix for https://issues.redhat.com/browse/OADP-5799
Depends on migtools/oadp-non-admin#260

How to test the changes made

  • Try passing logFormat via DPA as json or text
  • Check the NAC deployment/Pod for the value of LOG_FORMAT env var
  • Finally, check the format of logs in NAC controller pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025

@shubham-pampattiwar: This pull request references OADP-5799 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Why the changes were made

Fixes https://issues.redhat.com/browse/OADP-5799
Depends on migtools/oadp-non-admin#260
Fixes migtools/oadp-non-admin#254

How to test the changes made

  • Try passing logFormat via DPA as json or text
  • Check the NAC deployment/Pod for the value of LOG_FORMAT env var
  • Finally, check the format of logs in NAC controller pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Apr 1, 2025

@shubham-pampattiwar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Copy link
Member

kaovilai commented Apr 3, 2025

/lgtm

test if tide stopped merging with only single review + lgtm per update

@kaovilai kaovilai added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e03a52c into openshift:master Apr 3, 2025
7 checks passed
@shubham-pampattiwar
Copy link
Member Author

/cherry-pick oadp-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@shubham-pampattiwar: new pull request created: #1697

In response to this:

/cherry-pick oadp-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to set NAC logging to json format
5 participants