Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oadp-operator branch protection + enforce_admins: true #63459

Merged

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Apr 2, 2025

follow up to #63455
Signed-off-by: Tiger Kaovilai [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@kaovilai: no rehearsable tests are affected by this change

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 2, 2025
@kaovilai
Copy link
Member Author

kaovilai commented Apr 2, 2025

/cc @weshayutin

@openshift-ci openshift-ci bot requested a review from weshayutin April 2, 2025 22:54
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2025
Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 311eaaf into openshift:master Apr 3, 2025
10 checks passed
Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@kaovilai: Updated the config configmap in namespace ci at cluster app.ci using the following files:

  • key core-services-prow-02_config-openshift-oadp-operator-_prowconfig.yaml using file core-services/prow/02_config/openshift/oadp-operator/_prowconfig.yaml

In response to this:

follow up to #63455
Signed-off-by: Tiger Kaovilai [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants