OADP-5901: Add design for DataProtectionTest CRD and Controller #1706
Conversation
openshift-ci
bot
added
the
approved
shubham-pampattiwar
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@shubham-pampattiwar: This pull request references OADP-5901 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
docs/design/data-protection-test.md
Outdated
| metadata: | ||
| name: my-data-protection-test | ||
| spec: | ||
| backupLocation: |
There was a problem hiding this comment.
Would it make sense to also have spec.bslName -- validate that only one of bslName and backupLocation can be present -- that way if the BSL is already defined in the cluster, they don't need to copy all of that metadata over -- they can just reference the BSL by name.
There was a problem hiding this comment.
Hmm, yeah we can do that, optional name, but then it would be either the BSLConfig or the BSLName, not both.
There was a problem hiding this comment.
Done, added a note and updated DPT CRD.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shubham-pampattiwar, sseago, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@shubham-pampattiwar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
lgtm isn't working.. manual label |
openshift-merge-bot
bot
merged commit a772aaf
into
openshift:master
Why the changes were made
Design for DPT CRD and controller
How to test the changes made
Review the design