Skip to content

monitoring: Describe query log file feature for Prometheus #36495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

monitoring: Describe query log file feature for Prometheus #36495

wants to merge 1 commit into from

Conversation

philipgough
Copy link

@philipgough philipgough commented Sep 17, 2021 •
edited
Loading

This documents the changes made in openshift/cluster-monitoring-operator#1373 which enables Prometheus query log file https://prometheus.io/docs/guides/query-log/

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 17, 2021
@netlify
Copy link

netlify bot commented Sep 17, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 0e4e0c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6229dde98259e900082d5016

😎 Browse the preview: https://deploy-preview-36495--osdocs.netlify.app

@philipgough philipgough marked this pull request as ready for review September 20, 2021 09:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2021
@philipgough philipgough mentioned this pull request Oct 4, 2021
Merged
2 tasks
@Preeticp
Copy link
Contributor

Preeticp commented Oct 8, 2021

@philipgough thank you for the PR, please note that since this PR is for the 4.10 version of docs, we can merge this PR only post the 4.9 GA. Meanwhile, depending on @bburt-rh 's capacity he will start reviewing the PR.

@bburt-rh
Copy link
Contributor

This doc update is now being tracked in https://issues.redhat.com/browse/RHDEVDOCS-3401

@philipgough
Copy link
Author

philipgough commented Nov 15, 2021 •
edited
Loading

/hold

Depends on openshift/cluster-monitoring-operator#1373

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2021
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2022
jan--f
jan--f suggested changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A copy/paste error sneaked in.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2022
@bburt-rh
Copy link
Contributor

I've created an updated PR for this content at #43449

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 16, 2022

@philipgough: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh
Copy link
Contributor

@philipgough This PR can be closed, since the content from #43449 has already been completed and merged.

@kalexand-rh
Copy link
Contributor

@philipgough This PR can be closed, since the content from #43449 has already been completed and merged.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthaha sthaha sthaha left review comments

@jan--f jan--f jan--f requested changes

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@philipgough @Preeticp @bburt-rh @openshift-bot @kalexand-rh @jan--f @sthaha