Skip to content

RHDEVDOCS-3401 Document how to enable Prometheus query logs in OpenShift Monitoring #43449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2022
Merged

RHDEVDOCS-3401 Document how to enable Prometheus query logs in OpenShift Monitoring #43449

merged 1 commit into from
Mar 25, 2022

Conversation

bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Mar 17, 2022 •
edited
Loading

This PR documents how to enable Prometheus query logging for OpenShift monitoring

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2022
@bburt-rh bburt-rh mentioned this pull request Mar 17, 2022
Closed
@netlify
Copy link

netlify bot commented Mar 17, 2022 •
edited
Loading

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 44d272e
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/623c6876c50c540008d5461f
😎 Deploy Preview https://deploy-preview-43449--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jan--f
Copy link
Contributor

jan--f commented Mar 18, 2022

This lgtm! I think this landed in OCP 4.10, so no need to backport till 4.9 but @philipgough will know better.

jan--f
jan--f approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juzhao
Copy link

juzhao commented Mar 18, 2022 •
edited
Loading

This lgtm! I think this landed in OCP 4.10, so no need to backport till 4.9 but @philipgough will know better.

yes, it is since 4.10, see https://issues.redhat.com/browse/MON-1787, @philipgough we'd better fill in Fix Version/s field even for tasks, so we can know clearly, I have updated the field

jc-berger
jc-berger approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2022

@jc-berger: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh force-pushed the mon-1787 branch 2 times, most recently from 0a7ab9d to efc10b9 Compare March 18, 2022 18:34
@bburt-rh
Copy link
Contributor Author

This lgtm! I think this landed in OCP 4.10, so no need to backport till 4.9 but @philipgough will know better.

yes, it is since 4.10, see https://issues.redhat.com/browse/MON-1787, @philipgough we'd better fill in Fix Version/s field even for tasks, so we can know clearly, I have updated the field

Thanks for resolving this @juzhao

@bburt-rh bburt-rh force-pushed the mon-1787 branch 3 times, most recently from 2a7e826 to 707ae81 Compare March 18, 2022 19:47
@bburt-rh
Copy link
Contributor Author

@juzhao Can you please confirm my fixes and other updates and let me know if everything looks good? Thanks!

@juzhao
Copy link

juzhao commented Mar 21, 2022

lgtm

@Preeticp
Copy link
Contributor

Hi @bburt-rh this PR has two procedures in one module, we are asked not to house a module within another module. I suggest you split the prerequisites and the procedures into two separate modules, and maybe link to each other through additional resources. This would help in customers finding the relevant content easily.

@Preeticp Preeticp added lgtm Indicates that a PR is ready to be merged. dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.10 labels Mar 25, 2022
@Preeticp Preeticp added this to the Next Release milestone Mar 25, 2022
@Preeticp Preeticp merged commit b33f929 into openshift:main Mar 25, 2022
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.10

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #43814

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 25, 2022
Merged
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 25, 2022
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #43815

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh deleted the mon-1787 branch June 6, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Preeticp Preeticp Preeticp left review comments

@juzhao juzhao juzhao left review comments

@jan--f jan--f jan--f approved these changes

@philipgough philipgough philipgough approved these changes

@jc-berger jc-berger jc-berger approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.10 branch/enterprise-4.11 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
7 participants
@bburt-rh @jan--f @juzhao @Preeticp @openshift-cherrypick-robot @philipgough @jc-berger