Skip to content

[MULTIARCH-3975] New IBM Z LPAR installation assembly #71071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2024
Merged

[MULTIARCH-3975] New IBM Z LPAR installation assembly #71071

merged 1 commit into from
Feb 12, 2024

Conversation

SNiemann15
Copy link
Contributor

@SNiemann15 SNiemann15 commented Feb 1, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2024
@SNiemann15 SNiemann15 changed the title WIP - Add IBM Z LPAR installation assembly WIP [MULTIARCH-3975] New IBM Z LPAR installation assembly Feb 1, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 1, 2024 •
edited
Loading

🤖 Mon Feb 12 15:06:49 - Prow CI generated the docs preview: https://71071--ocpdocs-pr.netlify.app

@SNiemann15
Copy link
Contributor Author

/retest

@SNiemann15 SNiemann15 force-pushed the ibmz_lpar branch 4 times, most recently from cadf80d to 1ce575d Compare February 5, 2024 14:55
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2024
@SNiemann15 SNiemann15 force-pushed the ibmz_lpar branch 3 times, most recently from f744285 to 5709d5e Compare February 6, 2024 14:39
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2024
mjpytlak
mjpytlak reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@mjpytlak mjpytlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SNiemann15 Feedback for your review. Thanks.

@mjpytlak
Copy link
Contributor

mjpytlak commented Feb 6, 2024 •
edited
Loading

If you have questions about the rebase @SNiemann15 please reach out. @JoeAldinger deleted several ifeval statements that he had mistakenly added to a file (modules/installation-load-balancing-user-infra.adoc) on a rebase. You were also deleting these ifevals in modules/installation-load-balancing-user-infra.adoc. Happy to walk through it if it is not clear on what to do.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2024
@SNiemann15 SNiemann15 force-pushed the ibmz_lpar branch 2 times, most recently from 00be48a to 62a7cf3 Compare February 8, 2024 10:07
@sandisamp
Copy link

LGTM

@SNiemann15 SNiemann15 changed the title WIP [MULTIARCH-3975] New IBM Z LPAR installation assembly [MULTIARCH-3975] New IBM Z LPAR installation assembly Feb 9, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2024
@holgwolf
Copy link

LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2024

@SNiemann15: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bscott-rh bscott-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 12, 2024
@bscott-rh bscott-rh added this to the Planned for 4.15 GA milestone Feb 12, 2024
@bscott-rh
Copy link
Contributor

Added peer review done label per slack conversation with Mike.

@SNiemann15
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 12, 2024
@jab-rh jab-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 12, 2024
@jab-rh jab-rh merged commit 644ec4e into openshift:main Feb 12, 2024
@jab-rh
Copy link
Contributor

jab-rh commented Feb 12, 2024

/cherry-pick enterprise-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 12, 2024
Merged
@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #71486

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jab-rh jab-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 12, 2024
@JoeAldinger JoeAldinger added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 12, 2024
@SNiemann15 SNiemann15 deleted the ibmz_lpar branch March 1, 2024 10:15
@SNiemann15 SNiemann15 mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

@mjpytlak mjpytlak mjpytlak left review comments

@skopacz1 skopacz1 skopacz1 left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.15 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.15 GA
Development

Successfully merging this pull request may close these issues.