Skip to content

OSDOCS-9614: Created documentation to create a ROSA with HCP cluster that uses external auth for OIDC #73839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EricPonvelle
Copy link
Contributor

@EricPonvelle EricPonvelle commented Mar 27, 2024

Version(s):
enterprise-4.15+

Issue:
OSDOCS-9614

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR adds new documentation for external auth

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024

@EricPonvelle: This pull request references OSDOCS-9614 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
enterprise-4.15+

Issue:
OSDOCS-9614

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR adds new documentation for external auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2024
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 27, 2024

🤖 Wed May 08 15:00:18 - Prow CI generated the docs preview:
https://73839--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@EricPonvelle EricPonvelle force-pushed the OSDOCS-9614_External-OIDC-Auth-HCP branch 3 times, most recently from 1e992e2 to f6ab5cf Compare March 27, 2024 21:14
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9614_External-OIDC-Auth-HCP branch 5 times, most recently from e35951d to c04814b Compare April 5, 2024 13:14
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9614_External-OIDC-Auth-HCP branch 15 times, most recently from 1bc319f to 3ebfbfe Compare April 11, 2024 18:54
@opayne1 opayne1 added the peer-review-done Signifies that the peer review team has reviewed this PR label May 1, 2024
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9614_External-OIDC-Auth-HCP branch 3 times, most recently from 4af1a58 to 7eafc40 Compare May 2, 2024 12:15
@EricPonvelle EricPonvelle added the merge-review-needed Signifies that the merge review team needs to review this PR label May 7, 2024
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 7, 2024
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! Found some things to address consistency and style compliance wise, but overall this is solid.

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 7, 2024
Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note. It looks good!

@EricPonvelle EricPonvelle force-pushed the OSDOCS-9614_External-OIDC-Auth-HCP branch 5 times, most recently from 77f709c to 6f5f569 Compare May 8, 2024 13:31
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple little things left here, ping me when you've got them and I'll merge/CP

@EricPonvelle EricPonvelle force-pushed the OSDOCS-9614_External-OIDC-Auth-HCP branch from 6f5f569 to 4fd4e41 Compare May 8, 2024 14:42
@EricPonvelle EricPonvelle force-pushed the OSDOCS-9614_External-OIDC-Auth-HCP branch from 4fd4e41 to 35107fd Compare May 8, 2024 14:54
Copy link

openshift-ci bot commented May 8, 2024

@EricPonvelle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeana-redhat jeana-redhat added this to the Continuous Release milestone May 8, 2024
@jeana-redhat jeana-redhat merged commit 86e5424 into openshift:main May 8, 2024
3 checks passed
@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.16

@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@jeana-redhat: #73839 failed to apply on top of branch "enterprise-4.16":

Applying: OSDOCS-9614: Created documentation to create a ROSA with HCP cluster that uses external auth for OIDC
.git/rebase-apply/patch:87: trailing whitespace.
|--claim-mapping-groups-claim <string>     
.git/rebase-apply/patch:102: trailing whitespace.
|--console-client-secret <string>          
.git/rebase-apply/patch:228: trailing whitespace.
$ rosa create cluster --cluster-name=<cluster_name> --mode=auto \ 
.git/rebase-apply/patch:250: trailing whitespace.
 
.git/rebase-apply/patch:264: trailing whitespace.
$ rosa create cluster --hosted-cp --subnet-ids=$SUBNET_IDS \ 
warning: squelched 14 whitespace errors
warning: 19 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_attributes/attributes-openshift-dedicated.adoc
M	_topic_maps/_topic_map_rosa.yml
Falling back to patching base and 3-way merge...
Auto-merging _topic_maps/_topic_map_rosa.yml
Auto-merging _attributes/attributes-openshift-dedicated.adoc
CONFLICT (content): Merge conflict in _attributes/attributes-openshift-dedicated.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9614: Created documentation to create a ROSA with HCP cluster that uses external auth for OIDC
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jeana-redhat: #73839 failed to apply on top of branch "enterprise-4.15":

Applying: OSDOCS-9614: Created documentation to create a ROSA with HCP cluster that uses external auth for OIDC
.git/rebase-apply/patch:87: trailing whitespace.
|--claim-mapping-groups-claim <string>     
.git/rebase-apply/patch:102: trailing whitespace.
|--console-client-secret <string>          
.git/rebase-apply/patch:228: trailing whitespace.
$ rosa create cluster --cluster-name=<cluster_name> --mode=auto \ 
.git/rebase-apply/patch:250: trailing whitespace.
 
.git/rebase-apply/patch:264: trailing whitespace.
$ rosa create cluster --hosted-cp --subnet-ids=$SUBNET_IDS \ 
warning: squelched 14 whitespace errors
warning: 19 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_attributes/attributes-openshift-dedicated.adoc
M	_topic_maps/_topic_map_rosa.yml
Falling back to patching base and 3-way merge...
Auto-merging _topic_maps/_topic_map_rosa.yml
Auto-merging _attributes/attributes-openshift-dedicated.adoc
CONFLICT (content): Merge conflict in _attributes/attributes-openshift-dedicated.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9614: Created documentation to create a ROSA with HCP cluster that uses external auth for OIDC
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.