-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-9614: Created documentation to create a ROSA with HCP cluster that uses external auth for OIDC #73839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-9614: Created documentation to create a ROSA with HCP cluster that uses external auth for OIDC #73839
Conversation
@EricPonvelle: This pull request references OSDOCS-9614 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Wed May 08 15:00:18 - Prow CI generated the docs preview: |
1e992e2
to
f6ab5cf
Compare
e35951d
to
c04814b
Compare
1bc319f
to
3ebfbfe
Compare
4af1a58
to
7eafc40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work! Found some things to address consistency and style compliance wise, but overall this is solid.
/remove-label merge-review-in-progress
/remove-label merge-review-needed
modules/rosa-hcp-sts-creating-a-cluster-ext-auth-provider-delete-cli.adoc
Show resolved
Hide resolved
modules/rosa-hcp-sts-creating-a-cluster-ext-auth-provider-delete-cli.adoc
Show resolved
Hide resolved
modules/rosa-hcp-sts-creating-a-cluster-ext-auth-provider-delete-cli.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one note. It looks good!
77f709c
to
6f5f569
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple little things left here, ping me when you've got them and I'll merge/CP
modules/rosa-hcp-sts-creating-a-cluster-ext-auth-cluster-cli.adoc
Outdated
Show resolved
Hide resolved
modules/rosa-hcp-sts-creating-a-cluster-ext-auth-provider-cli.adoc
Outdated
Show resolved
Hide resolved
6f5f569
to
4fd4e41
Compare
…that uses external auth for OIDC
4fd4e41
to
35107fd
Compare
@EricPonvelle: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherrypick enterprise-4.16 |
/cherrypick enterprise-4.15 |
@jeana-redhat: #73839 failed to apply on top of branch "enterprise-4.16":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jeana-redhat: #73839 failed to apply on top of branch "enterprise-4.15":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
enterprise-4.15+
Issue:
OSDOCS-9614
Link to docs preview:
QE review:
Additional information:
This PR adds new documentation for external auth