Skip to content

OSDOCS#9971:Added breakglass feature modules for HCP clusters #73863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2024
Merged

OSDOCS#9971:Added breakglass feature modules for HCP clusters #73863

merged 1 commit into from
May 9, 2024

Conversation

AedinC
Copy link
Contributor

@AedinC AedinC commented Mar 28, 2024 •
edited
Loading

Version(s):
4.15+

Issue:
OSDOCS-9971

Link to docs preview:

Peer reviewer:

  • Peer reviewer has approved this change.

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

NOTE TO REVIEWERS:
This is a PR for the new breakglass feature which is a part of the Create a ROSA with HCP cluster that uses external auth for OIDC workflow that was worked on in #73839. We planned to merge these as closely as we could to each other, and #73839 was merged yesterday. Please only review these relevant break glass credential sections, as everything else has been reviewed as part of #73839:

  • Creating a break glass credential for a ROSA with HCP cluster
  • Accessing a ROSA with HCP cluster by using a break glass credential
  • Revoking a break glass credential for a ROSA with HCP cluster
  • Managing objects:
    • create a break glass credential
    • list a break glass credential
    • revoke a break glass credential

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 28, 2024 •
edited
Loading

🤖 Thu May 09 16:11:39 - Prow CI generated the docs preview:

https://73863--ocpdocs-pr.netlify.app/openshift-rosa/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html
https://73863--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_hcp/rosa-hcp-sts-creating-a-cluster-ext-auth.html

@AedinC AedinC force-pushed the OSDOCS-9971 branch 2 times, most recently from fd82b1f to abd1334 Compare March 28, 2024 13:16
@AedinC AedinC force-pushed the OSDOCS-9971 branch 7 times, most recently from 22e15b8 to 486303b Compare April 10, 2024 15:59
@AedinC
Copy link
Contributor Author

AedinC commented Apr 10, 2024

/retest

1 similar comment
@AedinC
Copy link
Contributor Author

AedinC commented Apr 12, 2024

/retest

@AedinC AedinC force-pushed the OSDOCS-9971 branch 9 times, most recently from dc672f3 to d63571a Compare April 15, 2024 16:15
@AedinC AedinC changed the title [WIP]OSDOCS#9971:Added breakglass feature modules for HCP clusters OSDOCS#9971:Added breakglass feature modules for HCP clusters Apr 15, 2024
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 15, 2024
@AedinC
Copy link
Contributor Author

AedinC commented Apr 15, 2024

/label peer-review-needed

@AedinC AedinC force-pushed the OSDOCS-9971 branch 5 times, most recently from 5bfb1f7 to bde396d Compare May 9, 2024 13:12
@AedinC
Copy link
Contributor Author

AedinC commented May 9, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 9, 2024
@adellape adellape self-assigned this May 9, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 9, 2024
adellape
adellape reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small fixes I think we should get in before merge. I'll keep merge-review-in-progress on and watch for an update to finish merging.

@AedinC
Copy link
Contributor Author

AedinC commented May 9, 2024

A couple small fixes I think we should get in before merge. I'll keep merge-review-in-progress on and watch for an update to finish merging.

Thanks @adellape!

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 9, 2024

@AedinC: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@AedinC
Copy link
Contributor Author

AedinC commented May 9, 2024

@adellape Is this ok to merge now?

@adellape adellape merged commit ec09577 into openshift:main May 9, 2024
3 checks passed
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.15

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 10, 2024
Merged
@openshift-cherrypick-robot
Copy link

@EricPonvelle: new pull request created: #75766

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@EricPonvelle: new pull request created: #75767

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 10, 2024
Merged
@AedinC AedinC mentioned this pull request May 10, 2024
Merged
@adellape
Copy link
Contributor

@AedinC Oops sorry I forgot the cherrypicks. @EricPonvelle ty for getting them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricPonvelle EricPonvelle EricPonvelle left review comments

@mburke5678 mburke5678 mburke5678 left review comments

@chenz4027 chenz4027 chenz4027 left review comments

@yingzhanredhat yingzhanredhat yingzhanredhat left review comments

@aaraj7 aaraj7 aaraj7 left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@adellape adellape adellape approved these changes

Assignees

@adellape adellape

Labels
branch/enterprise-4.15 branch/enterprise-4.16 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
10 participants
@AedinC @ocpdocs-previewbot @aaraj7 @EricPonvelle @openshift-cherrypick-robot @adellape @mburke5678 @chenz4027 @yingzhanredhat @ocpdocs-vale-bot