Skip to content

OSSM-3157 Update section Enabling automatic sidecar injection #75107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2024
Merged

OSSM-3157 Update section Enabling automatic sidecar injection #75107

merged 1 commit into from
Apr 30, 2024

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Apr 24, 2024 •
edited
Loading

OSSM-3157 Update section Enabling automatic sidecar injection

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSSM-3157

Link to docs preview:
https://75107--ocpdocs-pr.netlify.app/openshift-enterprise/latest/service_mesh/v2x/prepare-to-deploy-applications-ossm.html#ossm-automatic-sidecar-injection_deploying-applications-ossm

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 24, 2024 •
edited
Loading

🤖 Tue Apr 30 15:31:23 - Prow CI generated the docs preview:

https://75107--ocpdocs-pr.netlify.app/openshift-dedicated/latest/service_mesh/v2x/prepare-to-deploy-applications-ossm.html
https://75107--ocpdocs-pr.netlify.app/openshift-enterprise/latest/service_mesh/v1x/prepare-to-deploy-applications-ossm.html
https://75107--ocpdocs-pr.netlify.app/openshift-enterprise/latest/service_mesh/v2x/prepare-to-deploy-applications-ossm.html
https://75107--ocpdocs-pr.netlify.app/openshift-rosa/latest/service_mesh/v2x/prepare-to-deploy-applications-ossm.html

pbajjuri20
pbajjuri20 approved these changes Apr 29, 2024
View reviewed changes
Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..!

@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 30, 2024
@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 30, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 30, 2024

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 30, 2024
@opayne1 opayne1 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 30, 2024
opayne1
opayne1 reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@opayne1 opayne1 merged commit 5c65465 into openshift:main Apr 30, 2024
3 checks passed
@opayne1
Copy link
Contributor

opayne1 commented Apr 30, 2024

/cherrypick enterprise-4.12

@opayne1
Copy link
Contributor

opayne1 commented Apr 30, 2024

/cherrypick enterprise-4.13

@opayne1
Copy link
Contributor

opayne1 commented Apr 30, 2024

/cherrypick enterprise-4.14

@opayne1
Copy link
Contributor

opayne1 commented Apr 30, 2024

/cherrypick enterprise-4.15

@opayne1
Copy link
Contributor

opayne1 commented Apr 30, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@opayne1: new pull request created: #75367

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 30, 2024
Merged
@openshift-cherrypick-robot
Copy link

@opayne1: new pull request created: #75368

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 30, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@opayne1: new pull request created: #75369

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@opayne1: new pull request created: #75370

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 30, 2024
Merged
@openshift-cherrypick-robot
Copy link

@opayne1: new pull request created: #75371

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 30, 2024
Merged
JoeAldinger pushed a commit to JoeAldinger/openshift-docs that referenced this pull request Apr 30, 2024
@opayne1 @JoeAldinger
Merge pull request openshift#75107 from gwynnemonahan/OSSM-3157
88b76c6 
OSSM-3157 Update section Enabling automatic sidecar injection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@opayne1 opayne1 opayne1 left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@jewertow jewertow jewertow approved these changes

@pbajjuri20 pbajjuri20 pbajjuri20 approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gwynnemonahan @ocpdocs-previewbot @opayne1 @openshift-cherrypick-robot @jewertow @mburke5678 @pbajjuri20 @ocpdocs-vale-bot