Bug 2055861: Replace collect-profile jobs that haven't completed #255

awgreene · 2022-02-28T22:02:15Z

Problem: The collect-profiles job should only take a few seconds to
run. There are instances, such as when the pod cannot be scheduled,
where the job will not complete in a reasonable amount of time. If
enough jobs are scheduled but unable to run, the number of
scheduled jobs can exceed pod quota limits.

Solution: Given that the collect-profiles job should only take a few
seconds to run and that the job is scheduled to run every 15 minutes,
set the collect-profiles cronJob's spec.concurrencyPolicy to
"Replace" so that only one active collect-profiles pod exists at any
time.

openshift-ci · 2022-02-28T22:02:24Z

@awgreene: This pull request references Bugzilla bug 2055861, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 2055861: Replace collect-profile jobs that haven't completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-02-28T22:02:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-02-28T22:17:50Z

@awgreene: This pull request references Bugzilla bug 2055861, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 2055861: Replace collect-profile jobs that haven't completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Problem: The collect-profiles job should only take a few seconds to run. There are instances, such as when the pod cannot be scheduled, where the job will not complete in a reasonable amount of time. If enough jobs are scheduled but unable to run, the number of scheduled jobs can exceed pod quota limits. Solution: Given that the collect-profiles job should only take a few seconds to run and that the job is scheduled to run every 15 minutes, set the collect-profiles cronJob's spec.concurrencyPolicy to "Replace" so that only one active collect-profiles pod exists at any time.

perdasilva · 2022-03-01T10:16:31Z

/retest-required

perdasilva · 2022-03-01T12:31:47Z

/retest-required

perdasilva · 2022-03-02T22:12:54Z

/retest

petr-muller · 2022-03-03T16:09:47Z

/test images (trying something, sorry for the noise)

jianzhangbjz · 2022-03-04T01:23:15Z

/test e2e-upgrade
/test e2e-aws-olm

jianzhangbjz · 2022-03-04T07:59:42Z

/test e2e-upgrade
/test e2e-aws-olm

awgreene · 2022-03-16T12:19:56Z

/retest

jianzhangbjz · 2022-03-17T04:06:19Z

/label qe-approved

jianzhangbjz · 2022-03-17T05:59:17Z

/test e2e-upgrade
/test e2e-aws-olm

awgreene · 2022-03-22T13:36:38Z

/retest

awgreene · 2022-03-22T16:42:08Z

/retest

jianzhangbjz · 2022-03-25T07:22:37Z

/test e2e-aws-olm
/test e2e-gcp-olm

timflannagan · 2022-03-25T23:52:21Z

/test all

timflannagan · 2022-03-28T15:08:42Z

/retest-required

perdasilva · 2022-04-04T11:31:04Z

/test e2e-upgrade

perdasilva · 2022-04-04T14:32:07Z

/lgtm

perdasilva · 2022-04-04T15:31:21Z

/retest-required

perdasilva · 2022-04-04T16:38:46Z

/retest-required

perdasilva · 2022-04-04T17:54:00Z

/retest-required

perdasilva · 2022-04-04T18:00:19Z

/test e2e-gcp-console-olm
/test e2e-gcp-olm

openshift-ci · 2022-04-04T18:07:58Z

@awgreene: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-olm	`023eca4`	link	true	`/test e2e-aws-olm`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-04-04T19:10:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-04T19:34:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-04-04T21:14:48Z

@awgreene: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#255

Bugzilla bug 2055861 has been moved to the MODIFIED state.

In response to this:

Bug 2055861: Replace collect-profile jobs that haven't completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-04-05T07:05:42Z

/retest-required

timflannagan · 2022-04-05T14:29:06Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-04-05T14:29:52Z

@timflannagan: new pull request created: #277

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…shift#255) If the bundle is not present, the current bundleLoader will panic when it gets to addChannelsFromAnnotationsFile. If the bundle is nil, addChannelsFromAnnotationsFile should not attempt to do anything so instead it just returns now. Signed-off-by: Brad P. Crochet <[email protected]> Signed-off-by: Brad P. Crochet <[email protected]> Upstream-repository: api Upstream-commit: 5f99430d4ec47d59daafa3b818229f0466531dea

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 28, 2022

openshift-ci bot requested review from jianzhangbjz, benluddy and timflannagan February 28, 2022 22:02

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022

awgreene force-pushed the cronjob-replace-pending-jobs branch 2 times, most recently from 839d3bb to 4b19154 Compare February 28, 2022 22:10

awgreene force-pushed the cronjob-replace-pending-jobs branch from 4b19154 to be5dccf Compare February 28, 2022 22:28

awgreene force-pushed the cronjob-replace-pending-jobs branch from be5dccf to 023eca4 Compare February 28, 2022 22:32

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 17, 2022

openshift-ci bot assigned perdasilva Apr 4, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022

openshift-merge-robot merged commit 7e4eda4 into openshift:master Apr 4, 2022

openshift-cherrypick-robot mentioned this pull request Apr 5, 2022

[release-4.10] Bug 2071941: Replace collect-profile jobs that haven't completed #277

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2055861: Replace collect-profile jobs that haven't completed #255

Bug 2055861: Replace collect-profile jobs that haven't completed #255

awgreene commented Feb 28, 2022 •

edited

Loading

openshift-ci bot commented Feb 28, 2022

openshift-ci bot commented Feb 28, 2022

openshift-ci bot commented Feb 28, 2022

perdasilva commented Mar 1, 2022

perdasilva commented Mar 1, 2022

perdasilva commented Mar 2, 2022

petr-muller commented Mar 3, 2022

jianzhangbjz commented Mar 4, 2022

jianzhangbjz commented Mar 4, 2022

awgreene commented Mar 16, 2022

jianzhangbjz commented Mar 17, 2022

jianzhangbjz commented Mar 17, 2022

awgreene commented Mar 22, 2022

awgreene commented Mar 22, 2022

jianzhangbjz commented Mar 25, 2022

timflannagan commented Mar 25, 2022

timflannagan commented Mar 28, 2022

perdasilva commented Apr 4, 2022

perdasilva commented Apr 4, 2022

perdasilva commented Apr 4, 2022

perdasilva commented Apr 4, 2022

perdasilva commented Apr 4, 2022

perdasilva commented Apr 4, 2022

openshift-ci bot commented Apr 4, 2022 •

edited

Loading

openshift-bot commented Apr 4, 2022

openshift-bot commented Apr 4, 2022

openshift-ci bot commented Apr 4, 2022

perdasilva commented Apr 5, 2022

timflannagan commented Apr 5, 2022

openshift-cherrypick-robot commented Apr 5, 2022

Bug 2055861: Replace collect-profile jobs that haven't completed #255

Bug 2055861: Replace collect-profile jobs that haven't completed #255

Conversation

awgreene commented Feb 28, 2022 • edited Loading

openshift-ci bot commented Feb 28, 2022

openshift-ci bot commented Feb 28, 2022

openshift-ci bot commented Feb 28, 2022

perdasilva commented Mar 1, 2022

perdasilva commented Mar 1, 2022

perdasilva commented Mar 2, 2022

petr-muller commented Mar 3, 2022

jianzhangbjz commented Mar 4, 2022

jianzhangbjz commented Mar 4, 2022

awgreene commented Mar 16, 2022

jianzhangbjz commented Mar 17, 2022

jianzhangbjz commented Mar 17, 2022

awgreene commented Mar 22, 2022

awgreene commented Mar 22, 2022

jianzhangbjz commented Mar 25, 2022

timflannagan commented Mar 25, 2022

timflannagan commented Mar 28, 2022

perdasilva commented Apr 4, 2022

perdasilva commented Apr 4, 2022

perdasilva commented Apr 4, 2022

perdasilva commented Apr 4, 2022

perdasilva commented Apr 4, 2022

perdasilva commented Apr 4, 2022

openshift-ci bot commented Apr 4, 2022 • edited Loading

openshift-bot commented Apr 4, 2022

openshift-bot commented Apr 4, 2022

openshift-ci bot commented Apr 4, 2022

perdasilva commented Apr 5, 2022

timflannagan commented Apr 5, 2022

openshift-cherrypick-robot commented Apr 5, 2022

awgreene commented Feb 28, 2022 •

edited

Loading

openshift-ci bot commented Apr 4, 2022 •

edited

Loading