Skip to content

Not enough padding for overview loading message #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spadgett opened this issue Sep 11, 2017 · 5 comments · Fixed by #2050
Closed

Not enough padding for overview loading message #2049

spadgett opened this issue Sep 11, 2017 · 5 comments · Fixed by #2050
Assignees
@sg00dwin
Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3

Comments

@spadgett
Copy link
Member

screen shot 2017-09-11 at 1 30 09 pm
@spadgett spadgett added area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Sep 11, 2017
@sg00dwin
Copy link
Member

sg00dwin commented Sep 11, 2017 •
edited
Loading

I'm unable to reproduce. The element is getting the correct margin-top

origin-web-console/app/styles/_overview.less

Lines 361 to 363 in 375e384

.loading-message {
margin-top: 20px;
}

screen shot 2017-09-11 at 3 20 43 pm

@rhamilto what are you seeing?

@rhamilto
Copy link
Member

@rhamilto what are you seeing?

Looks ok for me, too.

screen shot 2017-09-11 at 4 13 54 pm

@spadgett
Copy link
Member Author

I think there's a scrollbar on the loading page, and I accidentally scrolled

@rhamilto
Copy link
Member

rhamilto commented Sep 11, 2017 •
edited
Loading

To resolve the issue where the scrollbar appears while "Loading..." is present, it looks like changing the top and bottom margins to padding on .empty-state-message and .empty-state-message h2 will fix the issue. Needs further testing...

@rhamilto rhamilto mentioned this issue Sep 11, 2017
Merged
@rhamilto rhamilto removed their assignment Sep 11, 2017
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Sep 12, 2017
@sg00dwin
Change margin to padding for loading message, so it doesn't cause scr…
6cafff1 
…ollbar during loading state.

Fixes openshift#2049
@spadgett
Copy link
Member Author

Yeah, it's definitely the scrollbar. Here is the uncropped screenshot.

screen shot 2017-09-11 at 1 30 09 pm

@sg00dwin sg00dwin mentioned this issue Sep 12, 2017
Merged
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Sep 12, 2017
@sg00dwin
Change margin to padding for loading message, so it doesn't cause scr…
f2b1996 
…ollbar during loading state.

Fixes openshift#2049
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@sg00dwin @f0x11
Change margin to padding for loading message, so it doesn't cause scr…
63f1a87 
…ollbar during loading state.

Fixes openshift#2049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sg00dwin sg00dwin

Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changing margin to padding on index.html .empty-state-message
3 participants
@rhamilto @spadgett @sg00dwin