Change margin to padding for loading message, so it doesn't cause scrollbar during loading state. #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollbar during loading state. Fixes openshift#2049
sg00dwin
force-pushed
the
loading-overview-scroll
branch
from
6cafff1 to
f2b1996
Compare
spadgett
approved these changes
Sep 12, 2017
|
[merge][severity:bug] |
|
#2053 should have fixed the dist problem. [merge][severity:bug] |
|
sigh looks like test flake #2016 is not fixed. [merge][severity:bug] |
|
Flake #1684 [merge][severity: bug] |
|
flake #2016 [merge][severity:bug] |
4 similar comments
|
flake #2016 [merge][severity:bug] |
|
flake #2016 [merge][severity:bug] |
|
flake #2016 [merge][severity:bug] |
|
flake #2016 [merge][severity:bug] |
|
[merge][severity:bug] |
|
Evaluated for origin web console merge up to f2b1996 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/190/) (Base Commit: 22e371a) (PR Branch Commit: f2b1996) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2049
after:
before:
