-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENV variable manager sluggish with lots of variables #620
Comments
we definitely shouldn't be sluggish at 40 env vars, its not that many. 1000 would have been a different story. @benjaminapetersen consider this next up after the membership stuff is done |
Agree. Standalone the kve has no prob with multiple instances on a page and many vars. Its likely related to the # of |
@andrewklau did you mean "sluggish" as in browser lag/response? I'm creating a few scenarios with a fairly absurd # of env vars and not experiencing that thus far. However, I can definitely see that the user experience is less than idea at a certain point. |
@benjaminapetersen yeah browser response when scrolling it kept jolting as I scrolled up and down the list (also when using the browser search function) |
@andrewklau Any chance there was a deployment in progress or something that could trigger many page updates? |
Ahhh OK, I can buy this causing a problem. So Ben you will need to set up a On Oct 15, 2016 1:54 AM, "Andrew Lau" [email protected] wrote:
|
Right. I don't think the editor itself has this performance issue so much as we are allowing it to be used when things are in flux. Thinking about how to solve -- is it reasonable to disable the editor in/in between certain states? |
@benjaminapetersen You might even use |
We have no |
- issue openshift#1863 could not pull second-to-last env var below last env var in kve - issue openshift#620 possibly helped (?) - bugzilla #1428991 reordering env vars down only works by twos - example: third moves to fifth, then seventh - bugzilla #1369315 possibly helped (?) I've mentioned 2 additional issues that may be helped by this fix as many quirky behaviors seem to resolve. That said, I will test more before closing them.
#2416 should at least partially fix this. |
- issue openshift#1863 could not pull second-to-last env var below last env var in kve - issue openshift#620 possibly helped (?) - bugzilla #1428991 reordering env vars down only works by twos - example: third moves to fifth, then seventh - bugzilla #1369315 possibly helped (?) I've mentioned 2 additional issues that may be helped by this fix as many quirky behaviors seem to resolve. That said, I will test more before closing them.
- issue openshift#1863 could not pull second-to-last env var below last env var in kve - issue openshift#620 possibly helped (?) - bugzilla #1428991 reordering env vars down only works by twos - example: third moves to fifth, then seventh - bugzilla #1369315 possibly helped (?) I've mentioned 2 additional issues that may be helped by this fix as many quirky behaviors seem to resolve. That said, I will test more before closing them.
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We had a case where a pod had two containers, both with about 20+ ENV variables set. This ended up being very sluggish for the user when scrolling down and modifying these ENV variables.
Perhaps they could be split by a dropdown box similar to the terminal and logs. Although if an individual container still had a lot of ENV variables it would still also be quite slow.
The text was updated successfully, but these errors were encountered: