Fix issue #1863, kve sort quirks, and bump ng-sortable #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- issue openshift#1863 could not pull second-to-last env var below last env var in kve - issue openshift#620 possibly helped (?) - bugzilla #1428991 reordering env vars down only works by twos - example: third moves to fifth, then seventh - bugzilla #1369315 possibly helped (?) I've mentioned 2 additional issues that may be helped by this fix as many quirky behaviors seem to resolve. That said, I will test more before closing them.
spadgett
reviewed
Aug 23, 2017
dist/scripts/scripts.js
Outdated
| @@ -13497,10 +13497,13 @@ uniqueForKey: r.uniqueForKey, | |||
| uniqueForValue: r.uniqueForValue, | |||
| dragControlListeners: { | |||
| accept: function(e, t) { | |||
| return e.itemScope.sortableScope.$id === t.$id; | |||
| return console.log("accept?"), e.itemScope.sortableScope.$id === t.$id; | |||
There was a problem hiding this comment.
Looks like there is some debug logging in the dist
There was a problem hiding this comment.
yup! got it.
|
Rebased. This one is def improvements on kve behavior. |
spadgett
approved these changes
Aug 28, 2017
|
[merge] |
|
@benjaminapetersen Can you test which are the bugs are really fixed so we can update the Bugzilla status? |
|
Evaluated for origin web console merge up to 1d03b58 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/85/) (Base Commit: c6ac85f) (PR Branch Commit: 1d03b58) |
|
@spadgett yup. I think the ones with the (?) are not sufficient, but the other ones are good. I'll give them another test run to make sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've mentioned 2 additional issues that may be helped by this fix as many quirky behaviors seem to resolve. That said, I will test more before closing them.
@rhamilto @spadgett