Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change constants.js help links to use configurable base URL #896

Closed
damemi opened this issue Nov 18, 2016 · 3 comments
Closed

Change constants.js help links to use configurable base URL #896

damemi opened this issue Nov 18, 2016 · 3 comments

Comments

@damemi
Copy link

damemi commented Nov 18, 2016

In constants.js, each doc link is hardcoded to direct to container platform docs. This means that for environments that extend these links, such as online and dedicated, a full copy of this list needs to be maintained and updated any time the link changes in constants.js.

Since the only difference is the base URL (ie, https://docs.openshift.com/container_platform/3.4/), propose changing these links to use a configurable window.OPENSHIFT_CONSTANTS.HELP_BASE_URL variable to reduce the number of variables that need to be maintained.

Example:
"cli": window.OPENSHIFT_CONSTANTS.HELP_BASE_URL+"/cli_reference/overview.html",

@jwforres
Copy link
Member

@damemi it will be in OCP 3.5, docs PR for reference on how to customize it openshift/openshift-docs#3268

@damemi
Copy link
Author

damemi commented Nov 22, 2016

@jwforres is there any reason it needs to wait for 3.5?

@jwforres
Copy link
Member

@damemi only significant blockers are going into 3.4 at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants