Allow the help base url to be configured to update docs links more easily #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spadgett PTAL |
|
actually hold, this isn't doing what i need it to |
jwforres
force-pushed
the
help-base-url
branch
from
a504787 to
7ed1fea
Compare
jwforres
commented
Nov 21, 2016
| @@ -192,7 +192,11 @@ angular.module('openshiftConsole') | |||
| }) | |||
| .filter('helpLink', function(Constants) { | |||
| return function(type) { | |||
| return Constants.HELP[type] || Constants.HELP["default"]; | |||
| var helpLink = Constants.HELP[type] || Constants.HELP["default"]; | |||
| if (!URI(helpLink).is('absolute')) { | |||
There was a problem hiding this comment.
this is to maintain our existing customization support
|
@spadgett ok ready now |
spadgett
approved these changes
Nov 22, 2016
|
[merge] |
|
Evaluated for origin web console merge up to 7ed1fea |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/752/) (Base Commit: 7389ce5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #896