[WIP] Don't show in-page alerts for create project #1781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checking to see if this breaks our integration tests. [test] |
jeff-phillips-18
approved these changes
Jun 30, 2017
Fixes an issue where both an in-page alert and toast notification can appear when there is an error creating a project.
spadgett
force-pushed
the
create-project-remove-alerts
branch
from
906026b to
ff3438d
Compare
|
Evaluated for origin web console test up to ff3438d |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1611/) (Base Commit: da50b08) (PR Branch Commit: ff3438d) |
|
Replaced by #1787 which has the common repo change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where both an in-page alert and toast notification can appear when there is an error creating a project.