Skip to content

Remove margin that causes errant spacing when build icon and message not shown #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

sg00dwin
Copy link
Member

and prevent aggressive wrapping of deployment message.

Before changes
screen shot 2017-07-11 at 2 16 03 pm

After changes
screen shot 2017-07-11 at 2 26 21 pm

@sg00dwin sg00dwin requested a review from rhamilto July 11, 2017 18:39
@@ -227,6 +234,12 @@
@media (min-width: @screen-sm-min) {
justify-content: flex-end;
}
@media(max-width: @screen-xs-max) {
&.deployment-in-progress-msg {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: indentation

@sg00dwin sg00dwin force-pushed the pf-list-overview-issues branch from ae6825c to 8062a65 Compare July 12, 2017 14:28
@sg00dwin
Copy link
Member Author

pr updated

@spadgett
Copy link
Member

@sg00dwin Need to fix dist files (try bower install && grunt build)

@sg00dwin sg00dwin force-pushed the pf-list-overview-issues branch from 8062a65 to eb83b0b Compare July 20, 2017 17:40
@sg00dwin
Copy link
Member Author

@spadgett updated pr

@spadgett
Copy link
Member

[merge][severity: bug]

@openshift-bot
Copy link

Evaluated for origin web console merge up to eb83b0b

@openshift-bot
Copy link

openshift-bot commented Jul 21, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/40/) (Base Commit: c607b86) (PR Branch Commit: eb83b0b) (Extended Tests: bug)

@openshift-bot openshift-bot merged commit 3355713 into openshift:master Jul 21, 2017
@sg00dwin sg00dwin deleted the pf-list-overview-issues branch July 26, 2017 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants