Bug 1481127 - More robust handling of large numbers of projects #1956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaylor113
approved these changes
Aug 21, 2017
spadgett
force-pushed
the
projects-list
branch
2 times, most recently
from
7c1f513 to
30f5447
Compare
spadgett
changed the title
|
@jeff-phillips-18 Still testing, but PTAL |
spadgett
force-pushed
the
projects-list
branch
from
30f5447 to
ae4aa51
Compare
app/views/projects.html
Outdated
| type-name-to-confirm="true" | ||
| stay-on-current-page="true" | ||
| alerts="alerts"> | ||
| </delete-link> | ||
| alerts="alerts" |
There was a problem hiding this comment.
The deleteProject directive does not use the alerts parameter.
spadgett
force-pushed
the
projects-list
branch
2 times, most recently
from
8ed8996 to
d23d5ca
Compare
spadgett
changed the title
spadgett
changed the title
|
@jeff-phillips-18 Another look? This should be ready. [test] |
jeff-phillips-18
approved these changes
Aug 23, 2017
- Don't watch extremely large project lists - Don't request projects on every page load - Increase debounce wait when filtering projects - Use `$applyAsync` instead of `$apply` to avoid digest in progress errors - Only show the first 250 projects on the project list. Users can filter or sort to see other projects - Don't show more than 100 projects in the header dropdown. Users can navigate back to the project list if they have more. - Let users type in the name of a project if the list fails. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1481127
spadgett
force-pushed
the
projects-list
branch
from
d23d5ca to
7ab78e3
Compare
|
Evaluated for origin web console test up to 7ab78e3 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/83/) (Base Commit: 5972dde) (PR Branch Commit: 7ab78e3) |
|
[merge][severity: blocker] |
|
Origin Web Console Merge Results: Waiting: You are in the build queue at position: 1 |
|
Evaluated for origin web console merge up to 7ab78e3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates origin-web-common to 0.0.47
Updates origin-web-catalog to 0.0.39
Updates uri.js to 1.18.12
$applyAsyncinstead of$applyto avoid digest in progress errorstrack byto project listng-repeatRequires openshift/origin-web-common#150
Requires openshift/origin-web-catalog#391
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1481127
Closes #1915
Closes #1923
TODO: