Update addConfigVolume controller to use getPreferredVersion #2096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't come up with much better unfortunately. We could use something really short like Any suggestions? |
|
Agree, have been thinking about it over weekend, nothing better comes to mind either. |
openshift-bot
added
the
needs-rebase
benjaminapetersen
force-pushed
the
bpetersen/trello-api-groups-config-volume
branch
from
8a35b55 to
b4af117
Compare
|
rebased & added view |
openshift-bot
removed
the
needs-rebase
spadgett
approved these changes
Sep 20, 2017
|
[merge] |
|
Evaluated for origin web console merge up to b4af117 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/235/) (Base Commit: e9c7620) (PR Branch Commit: b4af117) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving these along.
Depends on web console PR 161
Question still lingers, is
getPreferredVersionthe best name? I pause probably becauseversionbecomes overloaded. This just means "get what we are consistenly using", even though the method actually returns a{resource, group}w/o the version.@spadgett