Skip to content

Restore port icon with pficon-port #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Restore port icon with pficon-port #2324

merged 1 commit into from
Oct 20, 2017

Conversation

rhamilto
Copy link
Member

Fixes #2066

screen shot 2017-10-20 at 9 17 23 am

And bump angular-patternfly to v4.11.8 to pick up latest notification
drawer
and wizard bug fixes

Fixes #2066

And bump angular-patternfly to v4.11.8 to pick up latest notification
drawer and wizard bug fixes
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 20, 2017
@spadgett
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2017
@rhamilto
Copy link
Member Author

@sg00dwin, after this lands, check the notification drawer behavior/sizing because upstream changes...

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 57139b5 into openshift:master Oct 20, 2017
@rhamilto rhamilto deleted the issue-2066 branch October 20, 2017 15:06
openshift-merge-robot added a commit that referenced this pull request Oct 20, 2017
Automatic merge from submit-queue.

Incorporate badge-pf-bordered on notification drawer bell

IMPORTANT:  #2324 must merge first as it bumps PatternFly to a version
including the upstream change that includes badge-pf-bordered

<img width="67" alt="screen shot 2017-10-20 at 10 11 14 am" src="https://user-images.githubusercontent.com/895728/31825374-1124ba1e-b580-11e7-9d09-f0b0392771a2.PNG">
<img width="253" alt="screen shot 2017-10-20 at 10 11 27 am" src="https://user-images.githubusercontent.com/895728/31825375-11354f00-b580-11e7-85ae-89f77a15c3f0.PNG">
f0x11 pushed a commit to f0x11/origin-web-console that referenced this pull request Mar 26, 2018
IMPORTANT:  openshift#2324 must merge first as it bumps PatternFly to a version
including the upstream change that includes badge-pf-bordered
f0x11 pushed a commit to f0x11/origin-web-console that referenced this pull request Mar 26, 2018
IMPORTANT:  openshift#2324 must merge first as it bumps PatternFly to a version
including the upstream change that includes badge-pf-bordered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port icon doesn't display on container details
4 participants