-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-51373: use non-fake boot image for patch #29574
OCPBUGS-51373: use non-fake boot image for patch #29574
Conversation
Will wait on initial tests, but we should be able to use
|
@theobarberbany: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial |
@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5940adf0-f883-11ef-9470-6660726e10be-0 |
@theobarberbany: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-serial |
@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/79416db0-f883-11ef-9181-74063176096f-0 |
8b2d6de
to
3ace8b5
Compare
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-serial |
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial |
@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/91026560-f8e4-11ef-8467-ed7724e01a73-0 |
@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8c2dabd0-f8e4-11ef-974a-a9188adf4dcd-0 |
@theobarberbany: This pull request references Jira Issue OCPBUGS-51373, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial |
@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5863d150-f919-11ef-9527-95b4e956ccf5-0 |
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-serial |
@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5c62c450-f919-11ef-9292-cd52d6fa3c90-0 |
/retest |
Job Failure Risk Analysis for sha: 3ace8b5
|
3ace8b5
to
53d10e8
Compare
/lgtm |
/lgtm Thanks for the patch! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, JoelSpeed, theobarberbany The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Job Failure Risk Analysis for sha: 53d10e8
|
/test e2e-vsphere-ovn |
@theobarberbany: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2041600
into
openshift:main
@theobarberbany: Jira Issue OCPBUGS-51373: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-51373 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
/cherry-pick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14 release-4.13 |
@theobarberbany: new pull request created: #29584 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
These tests are failing as they use a fake disk image as part of a patch when checking GCP disk reconciliation.
This is due to recent changes with disk reconciliation on GCP: openshift/machine-api-provider-gcp#108. We now check if the disk is UEFI compatible before trying to create the machine.
This change updates the fake patch to use a real disk image.