Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-51373: use non-fake boot image for patch #29574

Merged

Conversation

theobarberbany
Copy link
Contributor

@theobarberbany theobarberbany commented Mar 3, 2025

These tests are failing as they use a fake disk image as part of a patch when checking GCP disk reconciliation.

This is due to recent changes with disk reconciliation on GCP: openshift/machine-api-provider-gcp#108. We now check if the disk is UEFI compatible before trying to create the machine.

This change updates the fake patch to use a real disk image.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2025
@openshift-ci openshift-ci bot requested review from djoshy and yuqi-zhang March 3, 2025 15:11
@theobarberbany
Copy link
Contributor Author

Will wait on initial tests, but we should be able to use family/centos-stream-9 which shouldn't break.

NAME                                                      PROJECT              FAMILY                                 DEPRECATED  STATUS
centos-stream-9-v20250212                                 centos-cloud         centos-stream-9                                    READY

Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

@theobarberbany: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@theobarberbany
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5940adf0-f883-11ef-9470-6660726e10be-0

Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

@theobarberbany: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@theobarberbany
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-serial

Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/79416db0-f883-11ef-9181-74063176096f-0

@theobarberbany theobarberbany force-pushed the tb/test-gcp-real-image branch from 8b2d6de to 3ace8b5 Compare March 4, 2025 10:36
@theobarberbany
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-serial

@theobarberbany
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/91026560-f8e4-11ef-8467-ed7724e01a73-0

Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8c2dabd0-f8e4-11ef-974a-a9188adf4dcd-0

@theobarberbany theobarberbany changed the title WIP: use non-fake boot image for patch OCPBUGS-51373: use non-fake boot image for patch Mar 4, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 4, 2025
@openshift-ci-robot
Copy link

@theobarberbany: This pull request references Jira Issue OCPBUGS-51373, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

These tests are failing as they use a fake disk image as part of a patch when checking GCP disk reconciliation.

This is due to recent changes with disk reconciliation on GCP: openshift/machine-api-provider-gcp#108. We now check if the disk is UEFI compatible before trying to create the machine.

This change updates the fake patch to use a real disk image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 March 4, 2025 10:37
@theobarberbany
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5863d150-f919-11ef-9527-95b4e956ccf5-0

@theobarberbany
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-serial

Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

@theobarberbany: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5c62c450-f919-11ef-9292-cd52d6fa3c90-0

@theobarberbany
Copy link
Contributor Author

/retest

Copy link

openshift-trt bot commented Mar 5, 2025

Job Failure Risk Analysis for sha: 3ace8b5

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive High
operator conditions etcd
This test has passed 98.85% of 260 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
Component Readiness: [Etcd] [operator-conditions] test regressed
---
[bz-etcd] pathological event should not see excessive RequiredInstallerResourcesMissing secrets
This test has passed 100.00% of 136 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[sig-node] static pods should start after being created
This test has passed 98.57% of 5019 runs on release 4.19 [Overall] in the last week.
---
[sig-node] node-lifecycle detects unexpected not ready node
This test has passed 99.58% of 5019 runs on release 4.19 [Overall] in the last week.

Open Bugs
[sig-node] node-lifecycle detects unexpected not ready node - test firing during apiserver gracefulshutdown
pull-ci-openshift-origin-main-e2e-gcp-disruptive High
[sig-node] node-lifecycle detects unexpected not ready node
This test has passed 98.77% of 81 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
[sig-node] node-lifecycle detects unexpected not ready node - test firing during apiserver gracefulshutdown
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling High
[bz-etcd][invariant] alert/etcdMembersDown should not be at or above info
This test has passed 100.00% of 2 runs on jobs [periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-etcd-scaling periodic-ci-openshift-release-master-nightly-4.18-e2e-gcp-ovn-etcd-scaling] in the last 14 days.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-etcd-scaling High
[sig-instrumentation] disruption/metrics-api connection/new should be available throughout the test
This test has passed 100.00% of 2 runs on jobs [periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-etcd-scaling periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-etcd-scaling] in the last 14 days.

@theobarberbany theobarberbany force-pushed the tb/test-gcp-real-image branch from 3ace8b5 to 53d10e8 Compare March 5, 2025 09:15
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2025
@djoshy
Copy link
Contributor

djoshy commented Mar 5, 2025

/lgtm
/approve

Thanks for the patch!

Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, JoelSpeed, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 585968f and 2 for PR HEAD 53d10e8 in total

Copy link

openshift-trt bot commented Mar 5, 2025

Job Failure Risk Analysis for sha: 53d10e8

Job Name Failure Risk
pull-ci-openshift-origin-main-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback MissingData
pull-ci-openshift-origin-main-e2e-aws-disruptive High
[sig-node] node-lifecycle detects unexpected not ready node
This test has passed 99.62% of 5195 runs on release 4.19 [Overall] in the last week.
---
[bz-Etcd] clusteroperator/etcd should not change condition/Available
This test has passed 99.94% of 5195 runs on release 4.19 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling Low
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 0.00% of 2 runs on jobs [periodic-ci-openshift-release-master-nightly-4.19-e2e-gcp-ovn-etcd-scaling periodic-ci-openshift-release-master-nightly-4.18-e2e-gcp-ovn-etcd-scaling] in the last 14 days.
pull-ci-openshift-origin-main-e2e-vsphere-ovn High
[sig-network] can collect pod-to-service poller pod logs
This test has passed 100.00% of 31 runs on jobs [periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn] in the last 14 days.

@theobarberbany
Copy link
Contributor Author

/test e2e-vsphere-ovn

Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

@theobarberbany: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-etcd-scaling 53d10e8 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-openstack-serial 53d10e8 link false /test e2e-openstack-serial
ci/prow/e2e-aws-ovn-single-node-serial 53d10e8 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-disruptive 53d10e8 link false /test e2e-gcp-disruptive
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 53d10e8 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-azure-ovn-etcd-scaling 53d10e8 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling 53d10e8 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-openstack-ovn 53d10e8 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 53d10e8 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-gcp-fips-serial 53d10e8 link false /test e2e-gcp-fips-serial
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 53d10e8 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-csi 53d10e8 link false /test e2e-gcp-csi
ci/prow/okd-e2e-gcp 53d10e8 link false /test okd-e2e-gcp
ci/prow/e2e-vsphere-ovn-etcd-scaling 53d10e8 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive 53d10e8 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2041600 into openshift:main Mar 5, 2025
38 of 53 checks passed
@openshift-ci-robot
Copy link

@theobarberbany: Jira Issue OCPBUGS-51373: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-51373 has been moved to the MODIFIED state.

In response to this:

These tests are failing as they use a fake disk image as part of a patch when checking GCP disk reconciliation.

This is due to recent changes with disk reconciliation on GCP: openshift/machine-api-provider-gcp#108. We now check if the disk is UEFI compatible before trying to create the machine.

This change updates the fake patch to use a real disk image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202503052011.p0.g2041600.assembly.stream.el9.
All builds following this will include this PR.

@theobarberbany
Copy link
Contributor Author

/cherry-pick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14 release-4.13

@openshift-cherrypick-robot

@theobarberbany: new pull request created: #29584

In response to this:

/cherry-pick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14 release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants