openshift · isabella-janssen · Mar 10, 2025 · Apr 3, 2025
diff --git a/test/extended/machine_config/OWNERS b/test/extended/machine_config/OWNERS
@@ -3,8 +3,18 @@ approvers:
   - dkhater-redhat
   - yuqi-zhang
   - cheesesashimi
+  - umohnani8
+  - LorbusChris
+  - RishabhSaini
+  - isabella-janssen
+  - pablintino
 reviewers:
   - djoshy
   - dkhater-redhat
   - yuqi-zhang
   - cheesesashimi
+  - umohnani8
+  - LorbusChris
+  - RishabhSaini
+  - isabella-janssen
+  - pablintino
diff --git a/test/extended/machine_config/helpers.go b/test/extended/machine_config/helpers.go
diff --git a/test/extended/machine_config/machine_config_node.go b/test/extended/machine_config/machine_config_node.go
diff --git a/test/extended/testdata/bindata.go b/test/extended/testdata/bindata.go
diff --git a/test/extended/testdata/machine_config/machineconfig/0-infra-mc.yaml b/test/extended/testdata/machine_config/machineconfig/0-infra-mc.yaml
@@ -0,0 +1,16 @@
+apiVersion: machineconfiguration.openshift.io/v1
+kind: MachineConfig
+metadata:
+  labels:
+    machineconfiguration.openshift.io/role: infra
+  name: 90-infra-testfile
+spec:
+  config:
+    ignition:
+      version: 3.2.0
+    storage:
+      files:
+      - contents:
+          source: data:,hello%20world%0A
+        mode: 420
+        path: /home/core/test
diff --git a/test/extended/testdata/machine_config/machineconfig/0-master-mc.yaml b/test/extended/testdata/machine_config/machineconfig/0-master-mc.yaml
@@ -0,0 +1,16 @@
+apiVersion: machineconfiguration.openshift.io/v1
+kind: MachineConfig
+metadata:
+  labels:
+    machineconfiguration.openshift.io/role: master
+  name: 90-master-testfile
+spec:
+  config:
+    ignition:
+      version: 3.2.0
+    storage:
+      files:
+      - contents:
+          source: data:,hello%20world%0A
+        mode: 420
+        path: /home/core/test
diff --git a/test/extended/testdata/machine_config/machineconfig/1-master-invalid-mc.yaml b/test/extended/testdata/machine_config/machineconfig/1-master-invalid-mc.yaml
@@ -0,0 +1,16 @@
+apiVersion: machineconfiguration.openshift.io/v1
+kind: MachineConfig
+metadata:
+  labels:
+    machineconfiguration.openshift.io/role: master
+  name: 91-master-testfile-invalid
+spec:
+  config:
+    ignition:
+      version: 3.2.0
+    storage:
+      files:
+      - contents:
+          source: data:,hello%20world%0A
+        mode: 420
+        path: /home/core
diff --git a/test/extended/testdata/machine_config/machineconfig/1-worker-invalid-mc.yaml b/test/extended/testdata/machine_config/machineconfig/1-worker-invalid-mc.yaml
@@ -0,0 +1,16 @@
+apiVersion: machineconfiguration.openshift.io/v1
+kind: MachineConfig
+metadata:
+  labels:
+    machineconfiguration.openshift.io/role: worker
+  name: 91-worker-testfile-invalid
+spec:
+  config:
+    ignition:
+      version: 3.2.0
+    storage:
+      files:
+      - contents:
+          source: data:,hello%20world%0A
+        mode: 420
+        path: /home/core
diff --git a/test/extended/testdata/machine_config/machineconfigpool/infra-mcp.yaml b/test/extended/testdata/machine_config/machineconfigpool/infra-mcp.yaml
@@ -0,0 +1,11 @@
+apiVersion: machineconfiguration.openshift.io/v1
+kind: MachineConfigPool
+metadata:
+  name: infra
+spec:
+  machineConfigSelector:
+    matchExpressions:
+      - {key: machineconfiguration.openshift.io/role, operator: In, values: [worker,infra]}
+  nodeSelector:
+    matchLabels:
+      node-role.kubernetes.io/infra: ""
diff --git a/test/extended/util/annotate/generated/zz_generated.annotations.go b/test/extended/util/annotate/generated/zz_generated.annotations.go
diff --git a/zz_generated.manifests/test-reporting.yaml b/zz_generated.manifests/test-reporting.yaml
@@ -98,6 +98,22 @@ spec:
     - testName: '[sig-imageregistry][OCPFeatureGate:ImageStreamImportMode][Serial]
         ImageStream API import mode should be PreserveOriginal or Legacy depending
         on desired.architecture field in the CV [apigroup:image.openshift.io]'
+  - featureGate: MachineConfigNodes
+    tests:
+    - testName: '[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block
+        MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io]'
+    - testName: '[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block
+        MCN updates from a MCD that is not the associated one [apigroup:machineconfiguration.openshift.io]'
+    - testName: '[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly update
+        the MCN from the associated MCD [apigroup:machineconfiguration.openshift.io]'
+    - testName: '[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have
+        MCN properties matching associated node properties [apigroup:machineconfiguration.openshift.io]'
+    - testName: '[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should properly
+        transition through MCN conditions on node update [apigroup:machineconfiguration.openshift.io]'
+    - testName: '[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should
+        properly create and remove MCN on node creation and deletion [apigroup:machineconfiguration.openshift.io]'
+    - testName: '[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should
+        properly report MCN conditions on node degrade [apigroup:machineconfiguration.openshift.io]'
   - featureGate: ManagedBootImages
     tests:
     - testName: '[sig-mco][OCPFeatureGate:ManagedBootImages][Serial] Should degrade