-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCO-1523: PinnedImageSet v1alpha1 Testing #29599
base: main
Are you sure you want to change the base?
Conversation
f988273
to
35d4a21
Compare
Job Failure Risk Analysis for sha: 35d4a21
|
c2d25fe
to
70ffa86
Compare
Job Failure Risk Analysis for sha: 70ffa86
Showing 20 of 44 jobs analysis Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 70ffa86
New tests seen in this PR at sha: 70ffa86
|
@RishabhSaini: This pull request references MCO-1523 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General test flow looks good to me - just a few nits. Nice work!
"sigs.k8s.io/yaml" | ||
) | ||
|
||
// This test is [Serial] because it modifies the cluster/machineconfigurations.operator.openshift.io object in each test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment doesn't match up here 😄 Also, serial/parallel maybe something to consider if you think these tests could be run in parallel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. I will holdoff running it in parallel till I can get a single clean run in CI
I'll defer to @hexfusion for the final tag, I'm happy with the current state. I don't see a tech preview variant in the default run presubmits, let's see if there's any we can call. /test ? |
@djoshy: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-gcp-ovn-techpreview |
/test e2e-gcp-ovn-techpreview-serial |
/test e2e-gcp-ovn-techpreview e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
/test e2e-aws-ovn-single-node-techpreview-serial e2e-aws-ovn-techpreview-serial |
/test e2e-gcp-ovn-techpreview e2e-gcp-ovn-techpreview-serial |
Job Failure Risk Analysis for sha: ed99368
|
/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
Job Failure Risk Analysis for sha: 4c6b336
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 4c6b336
New tests seen in this PR at sha: 4c6b336
|
Job Failure Risk Analysis for sha: 4c6b336
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 4c6b336
New tests seen in this PR at sha: 4c6b336
|
/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
/test e2e-aws-ovn-single-node-techpreview-serial |
/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
Job Failure Risk Analysis for sha: fff34f4
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: fff34f4
New tests seen in this PR at sha: fff34f4
|
Job Failure Risk Analysis for sha: fff34f4
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: fff34f4
New tests seen in this PR at sha: fff34f4
|
I am encountering this difference between local testing my PR and running it on CI: While local testing:
While the same is tested on CI. The wait time for the wait.PoollUntilContextCancel is set to 20 minutes however the run shows the CI job exits only after a couple of minutes.:
|
The test somehow only runs for 30 seconds as specified in the origin/test/extended/util/nodes.go Line 43 in b1cde86
|
/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
@RishabhSaini: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a61effb0-0ffc-11f0-992c-06d7020ade69-0 |
@RishabhSaini: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: 281bcc4
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 281bcc4
New tests seen in this PR at sha: 281bcc4
|
Job Failure Risk Analysis for sha: 281bcc4
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 281bcc4
New tests seen in this PR at sha: 281bcc4
|
/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
@RishabhSaini: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/918211d0-103f-11f0-905f-c1e859fa2c2e-0 |
No description provided.