Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSD-28717: Fix build failures of backplane-cli while bumping to version 1.23 #62885

Merged
merged 1 commit into from
Mar 18, 2025
Merged

OSD-28717: Fix build failures of backplane-cli while bumping to version 1.23 #62885

merged 1 commit into from
Mar 18, 2025

Conversation

Dee-6777
Copy link
Contributor

@Dee-6777 Dee-6777 commented Mar 17, 2025 •
edited
Loading

Bump backplane cli Go version to 1.23

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2025 •
edited by openshift-ci bot
Loading

@Dee-6777: This pull request references OSD-28717 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2025
@openshift-ci openshift-ci bot requested review from Tessg22 and typeid March 17, 2025 11:47
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2025 •
edited by openshift-ci bot
Loading

@Dee-6777: This pull request references OSD-28717 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Bump backplane cli Go version to 1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@feichashao
Copy link

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@feichashao: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Dee-6777: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-backplane-cli-main-build openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-coverage openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-images openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-lint openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-scan-optional openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-test openshift/backplane-cli presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

2 similar comments
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Dee-6777: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-backplane-cli-main-build openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-coverage openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-images openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-lint openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-scan-optional openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-test openshift/backplane-cli presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Dee-6777: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-backplane-cli-main-build openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-coverage openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-images openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-lint openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-scan-optional openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-test openshift/backplane-cli presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@feichashao
Copy link

/retest

@Dee-6777
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@Dee-6777: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Dee-6777
Copy link
Contributor Author

/retest

@Dee-6777
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@Dee-6777: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Dee-6777
Copy link
Contributor Author

/retest

@feichashao
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dee-6777, feichashao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Dee-6777
Copy link
Contributor Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@Dee-6777: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@Dee-6777: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5728700 into openshift:master Mar 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyu74 xiaoyu74 xiaoyu74 left review comments

@Tessg22 Tessg22 Awaiting requested review from Tessg22

@typeid typeid Awaiting requested review from typeid

Assignees

@feichashao feichashao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dee-6777 @openshift-ci-robot @feichashao @xiaoyu74