Cherry-pick annotation fixes for 1.6 #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are scenarios where an annotation may exist and adding a new annotation will fail if we don't use overwrite. Additionally delete the annotation on image deletion Fixes: #KATA-3117 Signed-off-by: Pradipta Banerjee <[email protected]> (cherry picked from commit f4c4eb9)
There are scenarios where an annotation may exist and adding a new annotation will fail if we don't use overwrite. Fixes: #KATA-3117 Signed-off-by: Pradipta Banerjee <[email protected]> (cherry picked from commit 2216229)
Use AMI instead of image where relevant as AWS uses AMI. Signed-off-by: Pradipta Banerjee <[email protected]> (cherry picked from commit 9c111b3)
bpradipt
requested review from
snir911 and
gkurz
and removed request for
littlejawa and
pmores
|
pre-merge testing completed successfully by @vvoronko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.