Skip to content

Bump to 1.8.1 #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Bump to 1.8.1 #480

merged 2 commits into from
Nov 29, 2024

Conversation

gkurz
Copy link
Member

@gkurz gkurz commented Nov 29, 2024

This is slighly improving the OSC version bump workflow and puts it in practice to prepare the release of OSC 1.8.1.

Bumping OSC version is a bit tricky as it should happen at many
locations scattered everywhere in the tree. Commit e2a4c34
introduced an `OSC_VERSION` tag to help tracking these locations.

Unfortunately, `make bundle` wreaks havoc in this logic as it
overwrites lines at several locations and drops the tag:
- everywhere in the `bundle` directory
- some locations in the base CSV
- a single location in `config/manager/kustomization.yaml`

As a result, we can only rely on `OSC_VERSION` for a subset of
the locations that need care. The other ones are:
- the `olm.skipRange` annotation in the base CSV
- the `spec.version` field in the base CSV
- the `spec.replaces` field in the base CSV

`make bundle` should then be run to propagate the version bump
to the rest of the repo.

Document all that.

While here set the tag for the metrics-server container that was
recently added.

Signed-off-by: Greg Kurz <[email protected]>
It is about time to bump for the upcoming release.

Fixes: https://issues.redhat.com/browse/KATA-3488

Signed-off-by: Greg Kurz <[email protected]>
Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

Copy link
Contributor

@littlejawa littlejawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks @gkurz !

@gkurz
Copy link
Member Author

gkurz commented Nov 29, 2024

Copy link

openshift-ci bot commented Nov 29, 2024

@gkurz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sandboxed-containers-operator-e2e 4e8e2b0 link false /test sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gkurz
Copy link
Member Author

gkurz commented Nov 29, 2024

ci/prow/sandboxed-containers-operator-e2e failure is expected (see openshift/release#59339 (comment) for details).

@gkurz gkurz merged commit f7060a9 into openshift:devel Nov 29, 2024
3 of 4 checks passed
@gkurz gkurz mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants