Backports for 1.8.1 #482
Merged
Backports for 1.8.1 #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those rules were added later, I missed this change. Signed-off-by: Beraldo Leal <[email protected]> (cherry picked from commit 8d8009d) Signed-off-by: Greg Kurz <[email protected]>
Not sure how we are going to deal with this, since this image is not published yet, only after the release. But we don't want to have the manifest pointing to 1.7. Signed-off-by: Beraldo Leal <[email protected]> (cherry picked from commit 7d0fed1) Signed-off-by: Greg Kurz <[email protected]>
This was the output of a `make bundle` command. Signed-off-by: Beraldo Leal <[email protected]> (cherry picked from commit d585289) Signed-off-by: Greg Kurz <[email protected]>
* azure: Delete source image on cleanup OSC creates the podvm image with packer by default and publishes it in a shared gallery. When the KataConfig CRD is deleted, OSC removes the gallery but the source image created by packer is left behind. This can generate uneeded storage costs to the customer. Fortunately, the path to the source image is available in the output of `az sig image-version show`. Fix the podvm image deletion flow to also delete the source image. Fixes: https://issues.redhat.com/browse/KATA-3462 Signed-off-by: Greg Kurz <[email protected]> (cherry picked from commit 310f0a3) Signed-off-by: Greg Kurz <[email protected]>
Apply the updates suggested by `govulncheck`: - go 1.22.7 - github.com/coreos/ignition/[email protected] Also run `go mod tidy`. Signed-off-by: Camilla Conte <[email protected]> (cherry picked from commit 9629eb3) Signed-off-by: Greg Kurz <[email protected]>
Signed-off-by: Camilla Conte <[email protected]> (cherry picked from commit f944f6b) Signed-off-by: Greg Kurz <[email protected]>
Bumping OSC version is a bit tricky as it should happen at many locations scattered everywhere in the tree. Commit e2a4c34 introduced an `OSC_VERSION` tag to help tracking these locations. Unfortunately, `make bundle` wreaks havoc in this logic as it overwrites lines at several locations and drops the tag: - everywhere in the `bundle` directory - some locations in the base CSV - a single location in `config/manager/kustomization.yaml` As a result, we can only rely on `OSC_VERSION` for a subset of the locations that need care. The other ones are: - the `olm.skipRange` annotation in the base CSV - the `spec.version` field in the base CSV - the `spec.replaces` field in the base CSV `make bundle` should then be run to propagate the version bump to the rest of the repo. Document all that. While here set the tag for the metrics-server container that was recently added. Signed-off-by: Greg Kurz <[email protected]> (cherry picked from commit 1c33256) Signed-off-by: Greg Kurz <[email protected]>
It is about time to bump for the upcoming release. Fixes: https://issues.redhat.com/browse/KATA-3488 Signed-off-by: Greg Kurz <[email protected]> (cherry picked from commit 4e8e2b0) Signed-off-by: Greg Kurz <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
We need to update containers/image dependency to v5.22+ As the dependency comes from machine-config, this commit brings it to the first version that depends on containers/image 5.22 Signed-off-by: Julien Ropé <[email protected]> (cherry picked from commit 03bf057) Signed-off-by: Greg Kurz <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
@gkurz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
CI is failing because 1.8.1 images aren't public yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports fixes from the following PRs for the upcoming release of OSC 1.8.1 :