Skip to content

s2i v1.5.0 Fails to Build for Windows #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adambkaplan opened this issue Jan 13, 2025 · 1 comment · Fixed by #1205
Closed

s2i v1.5.0 Fails to Build for Windows #1204

adambkaplan opened this issue Jan 13, 2025 · 1 comment · Fixed by #1205
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@adambkaplan
Copy link
Contributor

When trying to build v1.5.0 binaries for Windows, they fail with the following error:

# github.com/Microsoft/hcsshim/internal/oc
vendor/github.com/Microsoft/hcsshim/internal/oc/errors.go:21:39: undefined: errdefs.ToGRPC

This does not appear to be an issue for linux and darwin OS platforms.
@adambkaplan adambkaplan added the kind/bug Categorizes issue or PR as related to a bug. label Jan 13, 2025
@avinal
Copy link
Member

avinal commented Jan 15, 2025

This is because errdefs package has changed. Let me file a fix

@avinal avinal mentioned this issue Jan 15, 2025
Merged
adambkaplan added a commit to adambkaplan/source-to-image that referenced this issue Jan 16, 2025
@adambkaplan
fix: Verify Builds Cross-Compiled Binaries
38debb3 
Update the `verify` Makefile target to build cross-compiled binaries.
This ensures the s2i CLI can be released across all supported platforms
at all times. Prevents future regressions of openshift#1204.

Signed-off-by: Adam Kaplan <[email protected]>
@adambkaplan adambkaplan mentioned this issue Jan 16, 2025
Merged
adambkaplan added a commit to adambkaplan/source-to-image that referenced this issue Jan 16, 2025
@adambkaplan
fix: Verify Builds Cross-Compiled Binaries
658e409 
Update the `verify` Makefile target to build cross-compiled binaries.
This ensures the s2i CLI can be released across all supported platforms
at all times. Prevents future regressions of openshift#1204.

Signed-off-by: Adam Kaplan <[email protected]>
@adambkaplan adambkaplan mentioned this issue May 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update Microsoft/hcsshim to fix build on Windows avinal/source-to-image
2 participants
@adambkaplan @avinal