Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD-1165: Updating s2i to golang 1.22 #1191

Closed
wants to merge 1 commit into from

Conversation

adambkaplan
Copy link
Contributor

Updating the Dockerfile and go.mod to require golang 1.22. Changing the go runtime also requires a bump to the s2i minor version.

Dockerfile has also been updated to use the "patch" version of the UBI base images. This ensures we have reproducible builds, since the "patch" tags from Red Hat are effectively immutable. Konflux should also provide updates to the patch version through Renovate.

Updating the Dockerfile and go.mod to require golang 1.22. Changing the
go runtime also requires a bump to the s2i minor version.

Dockerfile has also been updated to use the "patch" version of the UBI
base images. This ensures we have reproducible builds, since the
"patch" tags from Red Hat are effectively immutable. Konflux should
also provide updates to the patch version through Renovate.

Signed-off-by: Adam Kaplan <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024

@adambkaplan: This pull request references BUILD-1165 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "s2i-1.5" instead.

In response to this:

Updating the Dockerfile and go.mod to require golang 1.22. Changing the go runtime also requires a bump to the s2i minor version.

Dockerfile has also been updated to use the "patch" version of the UBI base images. This ensures we have reproducible builds, since the "patch" tags from Red Hat are effectively immutable. Konflux should also provide updates to the patch version through Renovate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from divyansh42 and jkhelil November 7, 2024 15:58
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@adambkaplan
Copy link
Contributor Author

/hold

Frankly, our unit and integration tests should be moved to Konflux so we don't have to do the silly dance of updating openshift/release.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2024
@ayushsatyam146
Copy link
Contributor

@sayan-biswas this can be closed now

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2025
@sayan-biswas
Copy link
Contributor

Closing this since #1197 includes these changes.

@sayan-biswas
Copy link
Contributor

/close

Copy link
Contributor

openshift-ci bot commented Jan 5, 2025

@sayan-biswas: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Jan 5, 2025
Copy link
Contributor

openshift-ci bot commented Jan 5, 2025

@sayan-biswas: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot reopened this Jan 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 5, 2025

@adambkaplan: This pull request references BUILD-1165 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "s2i-1.5" instead.

In response to this:

Updating the Dockerfile and go.mod to require golang 1.22. Changing the go runtime also requires a bump to the s2i minor version.

Dockerfile has also been updated to use the "patch" version of the UBI base images. This ensures we have reproducible builds, since the "patch" tags from Red Hat are effectively immutable. Konflux should also provide updates to the patch version through Renovate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sayan-biswas
Copy link
Contributor

/retest

@sayan-biswas
Copy link
Contributor

/close

Copy link
Contributor

openshift-ci bot commented Jan 5, 2025

@sayan-biswas: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Jan 5, 2025
Copy link
Contributor

openshift-ci bot commented Jan 5, 2025

@adambkaplan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration d2311d8 link true /test integration
ci/prow/security d2311d8 link false /test security
ci/prow/verify d2311d8 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants