Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD-1165: Updating Dockerfile to us golang 1.22 image #1197

Merged

Conversation

ayushsatyam146
Copy link
Contributor

Mirror of #1191
Updating the Dockerfile to require golang 1.22. Golang version was already updated to 1.22.5

Dockerfile has also been updated to use the "patch" version of the UBI base images. This ensures we have reproducible builds, since the "patch" tags from Red Hat are effectively immutable. Konflux should also provide updates to the patch version through Renovate.

Updating the Dockerfile to require golang 1.22.
Changing the go runtime also requires a bump to the s2i minor version.

Dockerfile has also been updated to use the "patch" version of the UBI
base images. This ensures we have reproducible builds, since the
"patch" tags from Red Hat are effectively immutable. Konflux should
also provide updates to the patch version through Renovate.

Signed-off-by: Ayush Satyam <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2025

@ayushsatyam146: This pull request references BUILD-1165 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "s2i-1.5" instead.

In response to this:

Mirror of #1191
Updating the Dockerfile to require golang 1.22. Golang version was already updated to 1.22.5

Dockerfile has also been updated to use the "patch" version of the UBI base images. This ensures we have reproducible builds, since the "patch" tags from Red Hat are effectively immutable. Konflux should also provide updates to the patch version through Renovate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jkhelil and sayan-biswas January 3, 2025 04:03
Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

@ayushsatyam146: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 86a422b link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@sayan-biswas
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayushsatyam146, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sayan-biswas
Copy link
Contributor

sayan-biswas commented Jan 3, 2025

/override "Red Hat Konflux / source-to-image-enterprise-contract / source-to-image"

EC fails because of outdated tasks

Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

@sayan-biswas: Overrode contexts on behalf of sayan-biswas: Red Hat Konflux / source-to-image-enterprise-contract / source-to-image

In response to this:

/override "Red Hat Konflux / source-to-image-enterprise-contract / source-to-image"

outdate tasks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit fbf6f5c into openshift:master Jan 3, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants